Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-cloudwatch-metrics] fix: update enhanced_container_insights template from string to boolean #1062

Merged

Conversation

kangadrewie
Copy link
Contributor

@kangadrewie kangadrewie commented Feb 11, 2024

Issue

This value was being passed as a true string which was not been handled or considered in the CW Agent and was ultimately ignored.

Related issue - aws/amazon-cloudwatch-agent#1030

Description of changes

Modified the template to not wrap the boolean as a string.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

Updated ConfigMap generated by this helm to have true instead of "true". Applied changes and rolled out new daemonset resulting in Enhanced Observability metrics being sent to CW.

2024/02/11 19:39:07 D! config connectors: {}
exporters:
    awsemf/containerinsights:
        ...
        enhanced_container_insights: true
        imds_retries: 1
        local_mode: false
        log_group_name: /aws/containerinsights/{ClusterName}/performance
        log_retention: 0
        log_stream_name: '{NodeName}'
        ....

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ivan-sukhomlyn
Copy link

@M00nF1sh can you please take a look at this PR as well? 🙏 Thanks in advance!

@kangadrewie
Copy link
Contributor Author

Hey @M00nF1sh @bwagner5 can you help review this?

@kangadrewie
Copy link
Contributor Author

@M00nF1sh can I get a review on this please?

@shyamkhakhar9
Copy link

Can you please review and approve this

@jayanthvn jayanthvn merged commit 2c26551 into aws:master Mar 12, 2024
1 check passed
@jayanthvn
Copy link
Contributor

We will have a new release by early next week.

@shyamkhakhar9
Copy link

Thanks @jayanthvn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants