fix: honor use_aws_shared_config_files #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honor the `use_aws_shared_config_files` config from `default_region` and `default_sigv4a_signing_region_set` by passing `$args` along to the `ConfigurationResolver::resolve` call.
1 task
stobrien89
requested changes
Nov 20, 2024
yenfryherrerafeliz
force-pushed
the
fix_honor_use_aws_shared_config_files
branch
from
2234a20
to
3d58273
Compare
Add a single method for testing `use_aws_shared_config_files` config is passed along to the default config resolution.
yenfryherrerafeliz
force-pushed
the
fix_honor_use_aws_shared_config_files
branch
2 times, most recently
from
ff218bd
to
2e87233
Compare
stobrien89
requested changes
Nov 27, 2024
yenfryherrerafeliz
force-pushed
the
fix_honor_use_aws_shared_config_files
branch
from
2e87233
to
e2369a1
Compare
Resolve config default values that uses just the ConfigurationResolver::resolve method, from just a single method. This avoids the overhead of having layers of methods for just consuming `ConfigurationResolver::resolve`, and instead this one will be called directly.
yenfryherrerafeliz
force-pushed
the
fix_honor_use_aws_shared_config_files
branch
from
e2369a1
to
ad5f4a6
Compare
stobrien89
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honor the
use_aws_shared_config_filesconfig fromdefault_regionanddefault_sigv4a_signing_region_setby passing$argsalong to theConfigurationResolver::resolvecall.Issue #3026
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.