Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pdb and xml in NuGet package #118

Open
2 tasks
GabrielHare opened this issue May 14, 2023 · 2 comments
Open
2 tasks

Include pdb and xml in NuGet package #118

GabrielHare opened this issue May 14, 2023 · 2 comments
Labels
feature-request A feature should be added or improved. module/cognito-ext p2 This is a standard priority issue queued

Comments

@GabrielHare
Copy link
Contributor

Describe the feature

The NuGet packages for the standard AWS SDK include pdb and xml files.
Doing the same for these extensions would be nice... but it's not urgent, since this is a small open source project.

Use Case

Debug and documentation support for programmers using NuGet dll.

Proposed Solution

Follow the same NuGet package creation process as the standard AWS SDKs.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS .NET SDK and/or Package version used

AWS SDK Extensions for .NET Standard 2.0 (compatible with .NET Framework 4.5)
Version 2.4.1

Targeted .NET Platform

.NET Framework 4.5

Operating System and version

Ubuntu 22.04

@GabrielHare GabrielHare added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 14, 2023
@ashishdhingra
Copy link
Contributor

The HLL are published in release mode and PDB files are not included to reduce the size of NuGet package. For AWSSDK.Core 3.7.106.35, inspecting the package in NuGet Package Explorer shows the contained PDB and XML files.

Needs review with the team.

@ashishdhingra ashishdhingra added needs-review p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels May 15, 2023
@ashishdhingra
Copy link
Contributor

Per discussion with team, we should have the XML file in NuGet package if it is generated. We should enable source link for symbol packages.

@ashishdhingra ashishdhingra added p2 This is a standard priority issue queued and removed needs-review p3 This is a minor priority issue labels May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/cognito-ext p2 This is a standard priority issue queued
Projects
None yet
Development

No branches or pull requests

2 participants