diff --git a/aws-lc-fips-sys/builder/cmake_builder.rs b/aws-lc-fips-sys/builder/cmake_builder.rs index e4cda6dbb55..5d8baa1da6b 100644 --- a/aws-lc-fips-sys/builder/cmake_builder.rs +++ b/aws-lc-fips-sys/builder/cmake_builder.rs @@ -89,6 +89,7 @@ impl CmakeBuilder { cmake::Config::new(&self.manifest_dir) } + #[allow(clippy::too_many_lines)] fn prepare_cmake_build(&self) -> cmake::Config { let mut cmake_cfg = self.get_cmake_config(); diff --git a/aws-lc-fips-sys/builder/main.rs b/aws-lc-fips-sys/builder/main.rs index 053d8c17aa3..b5e06e7270a 100644 --- a/aws-lc-fips-sys/builder/main.rs +++ b/aws-lc-fips-sys/builder/main.rs @@ -381,7 +381,7 @@ fn prepare_cargo_cfg() { } bindgen_available!( - fn handle_bindgen(manifest_dir: &PathBuf, prefix: &Option) -> bool { + fn handle_bindgen(manifest_dir: &Path, prefix: &Option) -> bool { if internal_bindgen_supported() && !is_external_bindgen() { emit_warning(&format!( "Generating bindings - internal bindgen. Platform: {}", @@ -399,7 +399,7 @@ bindgen_available!( bindgen_available!( not, - fn handle_bindgen(_manifest_dir: &PathBuf, _prefix: &Option) -> bool { + fn handle_bindgen(_manifest_dir: &Path, _prefix: &Option) -> bool { false } ); diff --git a/aws-lc-rs/src/error.rs b/aws-lc-rs/src/error.rs index 5ba368c0e16..a754ae5a35b 100644 --- a/aws-lc-rs/src/error.rs +++ b/aws-lc-rs/src/error.rs @@ -165,6 +165,7 @@ impl Error for KeyRejected { } impl Error for Unspecified { + #[allow(clippy::unnecessary_literal_bound)] fn description(&self) -> &str { "Unspecified" } diff --git a/aws-lc-rs/tests/aead_test.rs b/aws-lc-rs/tests/aead_test.rs index 96ca9ad79bb..05e67d4a8a7 100644 --- a/aws-lc-rs/tests/aead_test.rs +++ b/aws-lc-rs/tests/aead_test.rs @@ -179,7 +179,7 @@ fn test_aead( // Debug builds are too slow for this, so for those builds, only // test a smaller subset. - let mut more_comprehensive_in_prefix_lengths = [0; 4096]; + let mut more_comprehensive_in_prefix_lengths = vec![0; 4096].into_boxed_slice(); let in_prefix_lengths = if cfg!(debug_assertions) { &MINIMAL_IN_PREFIX_LENS[..] } else { diff --git a/aws-lc-sys/builder/cc_builder.rs b/aws-lc-sys/builder/cc_builder.rs index e98b045c8be..4badc316216 100644 --- a/aws-lc-sys/builder/cc_builder.rs +++ b/aws-lc-sys/builder/cc_builder.rs @@ -394,7 +394,7 @@ impl crate::Builder for CcBuilder { Ok(()) } - fn name(&self) -> &str { + fn name(&self) -> &'static str { "CC" } } diff --git a/aws-lc-sys/builder/cmake_builder.rs b/aws-lc-sys/builder/cmake_builder.rs index 7e1403d7a13..a5a789acdc2 100644 --- a/aws-lc-sys/builder/cmake_builder.rs +++ b/aws-lc-sys/builder/cmake_builder.rs @@ -207,6 +207,7 @@ impl CmakeBuilder { cmake_cfg } + #[allow(clippy::unused_self)] fn configure_android(&self, _cmake_cfg: &mut cmake::Config) { // If we leave CMAKE_SYSTEM_PROCESSOR unset, then cmake-rs should handle properly setting // CMAKE_SYSTEM_NAME and CMAKE_SYSTEM_PROCESSOR: @@ -399,7 +400,7 @@ impl crate::Builder for CmakeBuilder { Ok(()) } - fn name(&self) -> &str { + fn name(&self) -> &'static str { "CMake" } } diff --git a/aws-lc-sys/builder/main.rs b/aws-lc-sys/builder/main.rs index c5824215a2f..1ecd3d5a95f 100644 --- a/aws-lc-sys/builder/main.rs +++ b/aws-lc-sys/builder/main.rs @@ -486,7 +486,7 @@ fn is_crt_static() -> bool { } bindgen_available!( - fn handle_bindgen(manifest_dir: &PathBuf, prefix: &Option) -> bool { + fn handle_bindgen(manifest_dir: &Path, prefix: &Option) -> bool { if internal_bindgen_supported() && !is_external_bindgen() { emit_warning(&format!( "Generating bindings - internal bindgen. Platform: {}", @@ -504,7 +504,7 @@ bindgen_available!( bindgen_available!( not, - fn handle_bindgen(_manifest_dir: &PathBuf, _prefix: &Option) -> bool { + fn handle_bindgen(_manifest_dir: &Path, _prefix: &Option) -> bool { false } );