-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent changes broke the Sentry AWS Lambda integration #172
Comments
This was referenced Sep 3, 2024
antonpirker
changed the title
Recent changes broke the Sentry AWS Lambda integration!
Recent changes broke the Sentry AWS Lambda integration
Sep 4, 2024
antonpirker
added a commit
to getsentry/sentry-python
that referenced
this issue
Sep 5, 2024
AWS changed their Lambda run times, so we no longer have access to the current exception during the init phase of the Lambda function. I am trying to fix this upstream: aws/aws-lambda-python-runtime-interface-client#172 This PR adds a fall back to the errror json object provided by AWS. This has way less data than a real exception in it, but it is better than nothing. Fixes #3464
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this issue
Sep 30, 2024
AWS changed their Lambda run times, so we no longer have access to the current exception during the init phase of the Lambda function. I am trying to fix this upstream: aws/aws-lambda-python-runtime-interface-client#172 This PR adds a fall back to the errror json object provided by AWS. This has way less data than a real exception in it, but it is better than nothing. Fixes getsentry#3464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello!
I am the maintainer of the sentry-sdk for python. We have an integration with AWS Lambda that allows users to capture unhandled errors during AWS Lambda init or invocation.
There was a change recently: https://github.com/aws/aws-lambda-python-runtime-interface-client/pull/163/files#diff-4513a869520b19ae4e30058106d7c3b5ddbb79216b5e9bd922d83389fb86c603R481-R483
This breaks our integration, because we monkey patch
post_init_error
and usesys.exc_info()
to access the currently handled exception.With this change linked above the call to
post_init_error
has moved outside the exception handling block, so we no longer have access to the currently handled exception.Is there any chance, we can move the call to
post_init_error
again under the exception handling block?I have also a PR for this: #171
The text was updated successfully, but these errors were encountered: