[479] CloudWatchEvent renamed to EventBridgeEvent #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
=======================================
Coverage 72.93% 72.93%
=======================================
Files 26 26
Lines 1456 1456
=======================================
Hits 1062 1062
Misses 322 322
Partials 72 72 ☔ View full report in Codecov by Sentry. |
bmoffatt
added
type/ux
type/events
bmoffatt
requested changes
Dec 19, 2023
|
Thank you for taking the time to suggest improvements @bmoffatt! I just made some changes as you suggested. Now it is as it should I guess. Let me know if it still needs more changes. |
bmoffatt
requested changes
Dec 22, 2023
bmoffatt
requested changes
Dec 23, 2023
bmoffatt
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #479
Description of changes:
Hi there! This should fix #479. Please, let me know if you meant something else!
Besides having renamed from CloudWatchEvent to EventBridgeEvent on some places of the code base, I also updated some links (despite they're still redirecting correctly)
Looking forward to your feedback! Thanks! :)