Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spec2cdk): remove accidentally added temporary schema #32465

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Dec 10, 2024

Issue # (if applicable)

N/A

Reason for this change

Accidentally added the temporary schema in https://github.com/aws/aws-cdk/pull/32204/files#diff-e0a6c532aa72e71d2fbedefa7286b214a0c0c39251595a11d84f415004d3d1ba. Should rely on the official CFN schema as it will contain the most up-to-date information.

Description of changes

Remove the temporary schema file.

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@GavinZZ GavinZZ marked this pull request as ready for review December 10, 2024 23:27
@aws-cdk-automation aws-cdk-automation requested a review from a team December 10, 2024 23:27
@github-actions github-actions bot added the p2 label Dec 10, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (2677fce) to head (e2ed5c7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32465      +/-   ##
==========================================
- Coverage   78.67%   78.66%   -0.02%     
==========================================
  Files         107      107              
  Lines        7237     7237              
  Branches     1329     1329              
==========================================
- Hits         5694     5693       -1     
- Misses       1357     1358       +1     
  Partials      186      186              
Flag Coverage Δ
suite.unit 78.66% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.66% <ø> (-0.02%) ⬇️

@GavinZZ GavinZZ merged commit c6c9f96 into main Dec 10, 2024
24 of 27 checks passed
@GavinZZ GavinZZ deleted the yuanhaoz/remove_temp_schema branch December 10, 2024 23:55
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e2ed5c7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants