Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): assuming a role from the INI file fails in non-commercial regions #32456

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

otaviomacedo
Copy link
Contributor

@otaviomacedo otaviomacedo commented Dec 10, 2024

SDK v3 is ignoring the region configuration if it's a non-commercial region, such as cn-*.

This PR also removes a duplicate test suite.

Fixes #32357.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 10, 2024 09:53
@github-actions github-actions bot added the p2 label Dec 10, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 10, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (59e96a3) to head (02ad485).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32456      +/-   ##
==========================================
- Coverage   78.67%   78.66%   -0.02%     
==========================================
  Files         107      107              
  Lines        7237     7237              
  Branches     1329     1329              
==========================================
- Hits         5694     5693       -1     
- Misses       1357     1358       +1     
  Partials      186      186              
Flag Coverage Δ
suite.unit 78.66% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.66% <ø> (-0.02%) ⬇️

@rix0rrr
Copy link
Contributor

rix0rrr commented Dec 10, 2024

SDK v3 is ignoring the region configuration if it's a non-commercial region, such as cn-*.

Technically speaking it always ignores it, which only becomes a visible problem in a non-commercial region 😛

@otaviomacedo otaviomacedo marked this pull request as ready for review December 10, 2024 10:58
@otaviomacedo otaviomacedo requested a review from a team as a code owner December 10, 2024 10:58
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p0 and removed p2 labels Dec 10, 2024
@otaviomacedo otaviomacedo added pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested labels Dec 10, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 10, 2024 12:37

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Dec 10, 2024
@rix0rrr rix0rrr changed the title fix(cli): authentication fails in non-commercial regions fix(cli): assuming a role from the INI file fails in non-commercial regions Dec 10, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 10, 2024
Copy link
Contributor

mergify bot commented Dec 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@@ -34,8 +34,8 @@ export class AwsCliCompatible {
requestHandler: AwsCliCompatible.requestHandlerBuilder(options.httpOptions),
customUserAgent: 'aws-cdk',
logger: options.logger,
region: await this.region(options.profile),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have unit test that ensures the region config is set so that the test will fail if one, in the future, accidentally removed this line?

@mergify mergify bot deployed to test-pipeline December 11, 2024 00:30 Active
Copy link
Contributor

mergify bot commented Dec 11, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 02ad485
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@otaviomacedo otaviomacedo merged commit 7028242 into main Dec 11, 2024
13 of 17 checks passed
@otaviomacedo otaviomacedo deleted the otaviom/fix-china branch December 11, 2024 09:46
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p0 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to perform AWS calls for account <account-number>, but no credentials have been configured
4 participants