feat(route53): added EvaluateTargetHealth to Route53 Alias targets (#9481) #30664

wladyslawczyzewski · 2024-06-25T20:12:03Z

Issue # (if applicable)

Part of a bigger piece of work for #9481
Another PR for this ticket #30739

Reason for this change

At this moment constructing the Route53 health checks is available only via L1 construct, this PR is one of the series to introduce the R53 health checks via higher-level constructs.

Description of changes

The underlying L1 construct of a few L2 constructs for Alias targets already has the EvaluateTargetHealth property, so by adding this prop to the L2 construct we get the quick win to introduce the health checks for Alias records.

Description of how you validated changes

unit tests
integration tests

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

wladyslawczyzewski · 2024-06-25T20:13:35Z

hey guys, this is my first contribution to this repo, I would be grateful for any feedback 🤝

default configuration of Alias target health check

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

…perty of Alias record

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

badmintoncryer

Thank you for your contribution!

Could you also create integ tests for targets other than ALB and Global Accelerator?

packages/aws-cdk-lib/aws-route53/lib/alias-record-target.ts

packages/aws-cdk-lib/aws-route53-targets/lib/bucket-website-target.ts

packages/aws-cdk-lib/aws-route53-targets/lib/classic-load-balancer-target.ts

packages/aws-cdk-lib/aws-route53-targets/lib/elastic-beanstalk-environment-target.ts

packages/aws-cdk-lib/aws-route53-targets/lib/global-accelerator-target.ts

packages/aws-cdk-lib/aws-route53-targets/lib/load-balancer-target.ts

packages/aws-cdk-lib/aws-route53-targets/lib/elastic-beanstalk-environment-target.ts

…rget.ts Co-authored-by: Kazuho Cryer-Shinozuka <[email protected]>

…ncer-target.ts Co-authored-by: Kazuho Cryer-Shinozuka <[email protected]>

…-environment-target.ts Co-authored-by: Kazuho Cryer-Shinozuka <[email protected]>

…r-target.ts Co-authored-by: Kazuho Cryer-Shinozuka <[email protected]>

…get.ts Co-authored-by: Kazuho Cryer-Shinozuka <[email protected]>

mergify · 2024-11-26T19:57:53Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

mergify · 2024-11-28T19:10:27Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

codecov · 2024-11-28T20:31:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (59e96a3) to head (ec0f368).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #30664   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files         107      107           
  Lines        7237     7237           
  Branches     1329     1329           
=======================================
  Hits         5694     5694           
  Misses       1357     1357           
  Partials      186      186

Flag	Coverage Δ
suite.unit	`78.67% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`78.67% <ø> (ø)`

GavinZZ · 2024-11-29T18:33:06Z

@mergify update

mergify · 2024-11-29T18:33:12Z

update

✅ Branch has been successfully updated

mergify · 2024-11-29T19:05:20Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

GavinZZ · 2024-12-03T20:24:43Z

@wladyslawczyzewski can you fix the merge conflicts? I've approved the PR and will prioritize on merging this once you fixed the conflicts. Thank you!

aws-cdk-automation · 2024-12-04T00:11:42Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2024-12-05T00:11:47Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

…s_health

…o route53_evaluate_alias_health

Pull request has been modified.

### Issue # (if applicable) Part of #9481 Another PR for this ticket #30664 ### Reason for this change Added L2 construct for `AWS::Route53::HealthCheck` resource ### Description of changes The changes only introduces the L2 construct for Route53 health check resources. Except the L2 construct itself, I added basic validations for the input props. ### Description of how you validated changes - unit tests - integration tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

mergify · 2024-12-10T23:54:13Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2024-12-10T23:58:58Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-12-11T00:11:41Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

…s_health

Pull request has been modified.

badmintoncryer · 2024-12-11T07:55:56Z

@wladyslawczyzewski
It’s better to comment @mergify update instead of manually merging the main branch after the maintainer’s approval. This allows you to update the branch without dismissing the maintainer’s review. 😁

aws-cdk-automation · 2024-12-11T08:24:08Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: ec0f368
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

feat(route53): added EvaluateTargetHealth to Route53 Alias targets

e7ceac5

github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 25, 2024

aws-cdk-automation requested a review from a team June 25, 2024 20:12

github-actions bot added the p2 label Jun 25, 2024

feat(route53): revert some previous changes to not introducing the

5d6aa97

default configuration of Alias target health check

aws-cdk-automation previously requested changes Jun 25, 2024

View reviewed changes

wladyslawczyzewski added 2 commits June 26, 2024 01:10

feat(route53): update integration tests for EvalueateTargetHealth pro…

070eda9

…perty of Alias record

feat(route53): update README file

d004bc9

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 25, 2024

wladyslawczyzewski changed the title ~~feat(route53): added EvaluateTargetHealth to Route53 Alias targets~~ feat(route53): added EvaluateTargetHealth to Route53 Alias targets (#9481) Jun 28, 2024

This was referenced Jul 1, 2024

Monthly PR metrics report #30715

Closed

Weekly PR metrics report #30720

Closed

Merge branch 'main' into route53_evaluate_alias_health

3ea3441

wladyslawczyzewski mentioned this pull request Jul 2, 2024

feat(route53): added L2 construct for Route53's health checks #30739

Merged

1 task

wladyslawczyzewski added 7 commits July 11, 2024 09:45

Merge branch 'main' into route53_evaluate_alias_health

83f2a95

Merge branch 'main' into route53_evaluate_alias_health

c93b2c9

Merge branch 'main' into route53_evaluate_alias_health

127acb3

Merge branch 'main' into route53_evaluate_alias_health

cab0113

Merge branch 'main' into route53_evaluate_alias_health

c524487

Merge branch 'main' into route53_evaluate_alias_health

a804541

Merge branch 'main' into route53_evaluate_alias_health

222d3da

lukepafford mentioned this pull request Sep 2, 2024

feat(route53): new Route53 CrossAccountRecordSet construct #31281

Closed

badmintoncryer suggested changes Oct 31, 2024

View reviewed changes

wladyslawczyzewski and others added 5 commits November 10, 2024 14:41

Update packages/aws-cdk-lib/aws-route53-targets/lib/bucket-website-ta…

dd2b02f

…rget.ts Co-authored-by: Kazuho Cryer-Shinozuka <[email protected]>

Update packages/aws-cdk-lib/aws-route53-targets/lib/classic-load-bala…

98c02af

…ncer-target.ts Co-authored-by: Kazuho Cryer-Shinozuka <[email protected]>

Update packages/aws-cdk-lib/aws-route53-targets/lib/elastic-beanstalk…

953964a

…-environment-target.ts Co-authored-by: Kazuho Cryer-Shinozuka <[email protected]>

Update packages/aws-cdk-lib/aws-route53-targets/lib/global-accelerato…

cf76e59

…r-target.ts Co-authored-by: Kazuho Cryer-Shinozuka <[email protected]>

Update packages/aws-cdk-lib/aws-route53-targets/lib/load-balancer-tar…

272294e

…get.ts Co-authored-by: Kazuho Cryer-Shinozuka <[email protected]>

Merge branch 'main' into route53_evaluate_alias_health

ae19705

GavinZZ previously approved these changes Nov 28, 2024

View reviewed changes

Merge branch 'main' into route53_evaluate_alias_health

2081fc5

Merge branch 'main' into route53_evaluate_alias_health

2c78477

wladyslawczyzewski added 2 commits December 6, 2024 14:19

Merge remote-tracking branch 'origin/main' into route53_evaluate_alia…

5043d97

…s_health

Merge remote-tracking branch 'fork/route53_evaluate_alias_health' int…

a4c4781

…o route53_evaluate_alias_health

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 6, 2024

wladyslawczyzewski requested a review from GavinZZ December 6, 2024 14:26

GavinZZ previously approved these changes Dec 10, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 10, 2024

Merge remote-tracking branch 'origin/main' into route53_evaluate_alia…

ec0f368

…s_health

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(route53): added EvaluateTargetHealth to Route53 Alias targets (#9481) #30664

feat(route53): added EvaluateTargetHealth to Route53 Alias targets (#9481) #30664

wladyslawczyzewski commented Jun 25, 2024 •

edited

Loading

wladyslawczyzewski commented Jun 25, 2024

aws-cdk-automation left a comment

badmintoncryer left a comment

mergify bot commented Nov 26, 2024

mergify bot commented Nov 28, 2024

codecov bot commented Nov 28, 2024 •

edited

Loading

GavinZZ commented Nov 29, 2024

mergify bot commented Nov 29, 2024

mergify bot commented Nov 29, 2024

GavinZZ commented Dec 3, 2024

aws-cdk-automation commented Dec 4, 2024

aws-cdk-automation commented Dec 5, 2024

mergify bot commented Dec 10, 2024

mergify bot commented Dec 10, 2024

aws-cdk-automation commented Dec 11, 2024

badmintoncryer commented Dec 11, 2024

aws-cdk-automation commented Dec 11, 2024

feat(route53): added EvaluateTargetHealth to Route53 Alias targets (#9481) #30664

Are you sure you want to change the base?

feat(route53): added EvaluateTargetHealth to Route53 Alias targets (#9481) #30664

Conversation

wladyslawczyzewski commented Jun 25, 2024 • edited Loading

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

wladyslawczyzewski commented Jun 25, 2024

aws-cdk-automation left a comment

Choose a reason for hiding this comment

badmintoncryer left a comment

Choose a reason for hiding this comment

mergify bot commented Nov 26, 2024

mergify bot commented Nov 28, 2024

codecov bot commented Nov 28, 2024 • edited Loading

Codecov Report

GavinZZ commented Nov 29, 2024

mergify bot commented Nov 29, 2024

✅ Branch has been successfully updated

mergify bot commented Nov 29, 2024

GavinZZ commented Dec 3, 2024

aws-cdk-automation commented Dec 4, 2024

aws-cdk-automation commented Dec 5, 2024

mergify bot commented Dec 10, 2024

mergify bot commented Dec 10, 2024

aws-cdk-automation commented Dec 11, 2024

badmintoncryer commented Dec 11, 2024

aws-cdk-automation commented Dec 11, 2024

AWS CodeBuild CI Report

wladyslawczyzewski commented Jun 25, 2024 •

edited

Loading

codecov bot commented Nov 28, 2024 •

edited

Loading