feat: lambda bundling with cdk-assets #22325

Hi-Fi · 2022-10-02T18:24:35Z

Currently there's no code generating asset manifest that would be using bundling. That generation is easier to build when there's some verified way to make bundling with cdk-assets.

Relates to at least following issues:
- (pipelines): bundle assets in the assets project instead of synth #19157
- (pipelines): make bundling of lambdas in asset stage as container images are done #21848

All Submissions:

Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

This PR adds new unconventional dependencies following the process described here

New Features

Have you added the new feature to an integration test?
- Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2022-10-02T18:24:43Z

aws-cdk-automation

The Pull Request Linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.

PRs must pass status checks before we can provide a meaningful review.

Pull Request updated. Dissmissing previous PRLinter Review.

aws-cdk-automation

The Pull Request Linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.

PRs must pass status checks before we can provide a meaningful review.

Pull request has been modified.

aws-cdk-automation

The Pull Request Linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

Pull Request updated. Dissmissing previous PRLinter Review.

aws-cdk-automation

The Pull Request Linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

Pull request has been modified.

aws-cdk-automation

The Pull Request Linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

aws-cdk-automation · 2022-10-02T19:14:39Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: b4d0c87
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Hi-Fi · 2022-10-03T03:46:36Z

packages/cdk-assets/lib/private/handlers/bundlable-files.ts

+    // Hack to get things tested
+    (this.asset.source.path as any) = bundledPath;


Currently added this hack to test things, but how this should be done?

add output path to assembly and pre-generate it when generating assemby?

modify publish part to allow overriding path with argument?

corymhall

@Hi-Fi thanks for taking the time to create this PR! Since this is labeled as a p2 and is adding some pretty significant functionality we will most likely not be able to review this without an RFC. I think there are a lot of ideas around how to enhance/refactor the assets/bundling functionality and it needs a much bigger discussion than is appropriate for a PR review.

Hi-Fi · 2022-10-03T12:46:52Z

@Hi-Fi thanks for taking the time to create this PR! Since this is labeled as a p2 and is adding some pretty significant functionality we will most likely not be able to review this without an RFC. I think there are a lot of ideas around how to enhance/refactor the assets/bundling functionality and it needs a much bigger discussion than is appropriate for a PR review.

@corymhall Just interested, how that p2 got here? Both referred issues are p1. At least earlier copied priority from issue.

Pull Request updated. Dissmissing previous PRLinter Review.

aws-cdk-automation

The Pull Request Linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

aws-cdk-automation · 2022-10-25T20:50:22Z

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

Hi-Fi · 2022-10-26T18:12:23Z

@corymhall was there something to improve in this PR, or was it just waiting auto-closure die inactivity after change to draft?

aws-cdk-automation · 2022-11-02T00:10:34Z

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

aws-cdk-automation · 2022-11-02T00:12:43Z

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Oct 2, 2022

aws-cdk-automation requested a review from a team October 2, 2022 18:24

github-actions bot added the p2 label Oct 2, 2022

aws-cdk-automation previously requested changes Oct 2, 2022

View reviewed changes

Hi-Fi changed the title ~~Feat/lambda bundling with cdk assets~~ feat: lambda bundling with cdk-assets Oct 2, 2022

Hi-Fi force-pushed the feat/lambda_bundling_with_cdk-assets branch from e02a2f2 to 1451315 Compare October 2, 2022 18:27

aws-cdk-automation previously requested changes Oct 2, 2022

View reviewed changes

Hi-Fi added 2 commits October 2, 2022 21:32

feat: added support for bundling to manifest

b730157

feat: allow bundling lambdas with cdk-assets

b4d0c87

Hi-Fi force-pushed the feat/lambda_bundling_with_cdk-assets branch from 1451315 to b4d0c87 Compare October 2, 2022 18:35

aws-cdk-automation previously requested changes Oct 2, 2022

View reviewed changes

Hi-Fi commented Oct 3, 2022

View reviewed changes

corymhall suggested changes Oct 3, 2022

View reviewed changes

corymhall marked this pull request as draft October 3, 2022 12:23

Naumel added the @aws-cdk/aws-lambda Related to AWS Lambda label Oct 4, 2022

aws-cdk-automation requested changes Oct 4, 2022

View reviewed changes

Hi-Fi mentioned this pull request Oct 12, 2022

(pipelines): make bundling of lambdas in asset stage as container images are done #21848

Open

2 tasks

Hi-Fi marked this pull request as ready for review October 26, 2022 18:12

aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Nov 2, 2022

aws-cdk-automation closed this Nov 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: lambda bundling with cdk-assets #22325

feat: lambda bundling with cdk-assets #22325

Hi-Fi commented Oct 2, 2022 •

edited

Loading

gitpod-io bot commented Oct 2, 2022

aws-cdk-automation left a comment

aws-cdk-automation left a comment

aws-cdk-automation left a comment

aws-cdk-automation left a comment

aws-cdk-automation left a comment

aws-cdk-automation commented Oct 2, 2022

Hi-Fi Oct 3, 2022

corymhall left a comment

Hi-Fi commented Oct 3, 2022 •

edited

Loading

aws-cdk-automation left a comment

aws-cdk-automation commented Oct 25, 2022

Hi-Fi commented Oct 26, 2022

aws-cdk-automation commented Nov 2, 2022

aws-cdk-automation commented Nov 2, 2022

		// Hack to get things tested
		(this.asset.source.path as any) = bundledPath;

feat: lambda bundling with cdk-assets #22325

feat: lambda bundling with cdk-assets #22325

Conversation

Hi-Fi commented Oct 2, 2022 • edited Loading

All Submissions:

Adding new Unconventional Dependencies:

New Features

gitpod-io bot commented Oct 2, 2022

aws-cdk-automation left a comment

Choose a reason for hiding this comment

aws-cdk-automation left a comment

Choose a reason for hiding this comment

aws-cdk-automation left a comment

Choose a reason for hiding this comment

aws-cdk-automation left a comment

Choose a reason for hiding this comment

aws-cdk-automation left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Oct 2, 2022

AWS CodeBuild CI Report

Hi-Fi Oct 3, 2022

Choose a reason for hiding this comment

corymhall left a comment

Choose a reason for hiding this comment

Hi-Fi commented Oct 3, 2022 • edited Loading

aws-cdk-automation left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Oct 25, 2022

Hi-Fi commented Oct 26, 2022

aws-cdk-automation commented Nov 2, 2022

aws-cdk-automation commented Nov 2, 2022

Hi-Fi commented Oct 2, 2022 •

edited

Loading

Hi-Fi commented Oct 3, 2022 •

edited

Loading