Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: everywhere we use a waiter we have to adjust the message to take waiter errors into account #32481

Open
2 tasks
rix0rrr opened this issue Dec 11, 2024 · 1 comment
Open
2 tasks

cli: everywhere we use a waiter we have to adjust the message to take waiter errors into account #32481

rix0rrr opened this issue Dec 11, 2024 · 1 comment
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Dec 11, 2024

Describe the feature

This PR smithy-lang/smithy-typescript#1467 changed the information that is contained in an error thrown from a waiter.

We must include the additional error detail in the message we print to the screen.

Use Case

If we do not, permissions errors are invisible.

While we're at it, see also: #32237

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

Environment details (OS name and version, etc.)
@rix0rrr rix0rrr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 11, 2024
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Dec 11, 2024
@rix0rrr rix0rrr mentioned this issue Dec 11, 2024
Open
1 task
@ashishdhingra ashishdhingra self-assigned this Dec 11, 2024
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Dec 11, 2024
@ashishdhingra
Copy link
Contributor

Opened by CDK team. Marking it as p2.

@ashishdhingra ashishdhingra added effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 11, 2024
@ashishdhingra ashishdhingra removed their assignment Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rix0rrr @ashishdhingra