Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IoHost used as only logger everywhere #32346

Open
mrgrain opened this issue Dec 1, 2024 · 0 comments
Open

IoHost used as only logger everywhere #32346

mrgrain opened this issue Dec 1, 2024 · 0 comments
Assignees
@HBobertz

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Dec 1, 2024 •
edited
Loading

With #32345 completed, we can move to using the IoHost.

  • create a global singleton CliIoHost
  • change every log statement to use the new CliIoHost
  • remove all other logger implementations, instead every call must call ioHost.notify(...)
  • We cannot not have helpers to call notify
  • However we can have helper methods to create IoMessages of the correct type, i.e. ioHost.notify(error("momo made a boo boo")) is fine

This should not require any changes to tests. If so, explain why.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HBobertz HBobertz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrgrain @HBobertz