Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IoHost logger-only implementation #32345

Open
mrgrain opened this issue Dec 1, 2024 · 0 comments · May be fixed by #32503
Open

IoHost logger-only implementation #32345

mrgrain opened this issue Dec 1, 2024 · 0 comments · May be fixed by #32503
Assignees

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Dec 1, 2024

From the RFC implement a private CliIoHost class that satisfies the notify(...) method of the interface and required message interfaces.

interface IIoHost {
  /**
   * Notifies the host of a message.
   * The caller waits until the notification completes.
   */
  notify<T>(msg: IoMessage<T>): Promise<void>;
}

The implementation should follow the existing logging implementation. However this ticket will not change any existing functionality.

  • You don't need to have an interface just the implementations.
  • Create IoMessage except for the data property
  • Add all code to new files into a new toolkit subdirectory in the cli package.
  • None of these classes and files should be exported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants