Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(events-targets): Support all input overrides for EcsTask target #32217

Open
1 of 2 tasks
blimmer opened this issue Nov 20, 2024 · 1 comment
Open
1 of 2 tasks

(events-targets): Support all input overrides for EcsTask target #32217

blimmer opened this issue Nov 20, 2024 · 1 comment
Labels
@aws-cdk/aws-events-targets effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@blimmer
Copy link
Contributor

blimmer commented Nov 20, 2024

Describe the feature

ECS targets can override any item in the TaskOverride structure via the input parameter, according to the docs.

However, today, only the containerOverrides option is exposed:

const containerOverrides = this.props.containerOverrides && this.props.containerOverrides
.map(({ containerName, ...overrides }) => ({ name: containerName, ...overrides }));
const input = { containerOverrides };

Use Case

I need to override CPU/Memory at the Task Definition level, but CDK doesn't currently expose that option.

Proposed Solution

All input options (documented in the TaskOverride structure docs) should be allowed. Specifically, these are missing today:

  • cpu
  • ephemeralStorage
  • executionRoleArn
  • inferenceAcceleratorOverrides
  • memory
  • taskRoleArn

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.168.0

Environment details (OS name and version, etc.)

Mac, Node 20 LTS

@blimmer blimmer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 20, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 20, 2024
@khushail khushail self-assigned this Nov 20, 2024
@khushail
Copy link
Contributor

Thanks @blimmer for raising this request. All input overrrides are supported by Cloudformation and it would be useful to set them through CDK as well. Appreciate you volunterring for PR contribution. Looking forward to your PR!

@khushail khushail added p2 and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Nov 21, 2024
@khushail khushail removed their assignment Nov 21, 2024
@khushail khushail added the effort/small Small work item – less than a day of effort label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-events-targets effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants