Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(pipelines): generate shell script and call that in assets instead of requiring self mutation #19136

Closed
1 of 2 tasks
Hi-Fi opened this issue Feb 24, 2022 · 3 comments
Closed
1 of 2 tasks
Assignees
Labels
@aws-cdk/pipelines CDK Pipelines library feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@Hi-Fi
Copy link
Contributor

Hi-Fi commented Feb 24, 2022

Description

Currently asset stage command are directly at the build spec. Those include e.g. image hashes, that require self mutation to get new image published.

If synth would just generate command to shell script and asset stage call that shell script (as it already get the input from cdk.out) purely application updates woudn't require self mutation.

Use Case

  • Simplifies and speeds up running
  • No need to have self mutation enabled

Proposed Solution

  • generate shell script to cdk.out during synth that handles the cdk-assets calls
  • Call "statically" that shell script so that self mutate step doesn't need to be updated all the time

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@Hi-Fi Hi-Fi added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 24, 2022
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Feb 24, 2022
@rix0rrr
Copy link
Contributor

rix0rrr commented Feb 24, 2022

Duplicate of #9080

@rix0rrr rix0rrr marked this as a duplicate of #9080 Feb 24, 2022
@rix0rrr rix0rrr closed this as completed Feb 24, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@hoegertn
Copy link
Contributor

Using publishAssetsInParallel: false on the pipeline you can achieve this to some degree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants