{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":105808767,"defaultBranch":"main","name":"aws-cdk","ownerLogin":"aws","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-10-04T19:22:36.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/2232217?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1727529871.0","currentOid":""},"activityList":{"items":[{"before":"37348be892ceac9866ad131e8f963f4b93251b59","after":"e3ad0cdce1fceb992ff985ffb82edf57b1ae0fe3","ref":"refs/heads/test-main-pipeline","pushedAt":"2024-09-30T06:40:17.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"aws-cdk-automation","name":"AWS CDK Automation","path":"/aws-cdk-automation","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43080478?s=80&v=4"},"commit":{"message":"mid work","shortMessageHtmlLink":"mid work"}},{"before":"12e2c98936fc620d182e2b50e4f01510d60bed92","after":"e3ad0cdce1fceb992ff985ffb82edf57b1ae0fe3","ref":"refs/heads/epolon/notices-on-bootstrap-version","pushedAt":"2024-09-30T06:24:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iliapolo","name":"Eli Polonsky","path":"/iliapolo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1428812?s=80&v=4"},"commit":{"message":"mid work","shortMessageHtmlLink":"mid work"}},{"before":"37348be892ceac9866ad131e8f963f4b93251b59","after":"12e2c98936fc620d182e2b50e4f01510d60bed92","ref":"refs/heads/epolon/notices-on-bootstrap-version","pushedAt":"2024-09-30T04:22:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"iliapolo","name":"Eli Polonsky","path":"/iliapolo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1428812?s=80&v=4"},"commit":{"message":"Update README.md","shortMessageHtmlLink":"Update README.md"}},{"before":"1d94db2b18ebf8f1cfd774cd0deecadedb04d2fc","after":"37348be892ceac9866ad131e8f963f4b93251b59","ref":"refs/heads/test-main-pipeline","pushedAt":"2024-09-29T19:53:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-cdk-automation","name":"AWS CDK Automation","path":"/aws-cdk-automation","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43080478?s=80&v=4"},"commit":{"message":"mid work","shortMessageHtmlLink":"mid work"}},{"before":"e2ad953b2d121ef4545bbc76aaa7e67ae6e1847c","after":"37348be892ceac9866ad131e8f963f4b93251b59","ref":"refs/heads/epolon/notices-on-bootstrap-version","pushedAt":"2024-09-29T19:50:04.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"iliapolo","name":"Eli Polonsky","path":"/iliapolo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1428812?s=80&v=4"},"commit":{"message":"mid work","shortMessageHtmlLink":"mid work"}},{"before":"e2ad953b2d121ef4545bbc76aaa7e67ae6e1847c","after":"1d94db2b18ebf8f1cfd774cd0deecadedb04d2fc","ref":"refs/heads/test-main-pipeline","pushedAt":"2024-09-28T16:06:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-cdk-automation","name":"AWS CDK Automation","path":"/aws-cdk-automation","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43080478?s=80&v=4"},"commit":{"message":"Merge branch 'main' into bobertzh/v3Migration","shortMessageHtmlLink":"Merge branch 'main' into bobertzh/v3Migration"}},{"before":"4adb0e588e7a8b6397bc2b9038c6460be27d3501","after":"1d94db2b18ebf8f1cfd774cd0deecadedb04d2fc","ref":"refs/heads/bobertzh/v3Migration","pushedAt":"2024-09-28T16:04:00.000Z","pushType":"push","commitsCount":17,"pusher":{"login":"HBobertz","name":"Hogan Bobertz","path":"/HBobertz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/18233297?s=80&v=4"},"commit":{"message":"Merge branch 'main' into bobertzh/v3Migration","shortMessageHtmlLink":"Merge branch 'main' into bobertzh/v3Migration"}},{"before":"248b2c1368fbbc4bfefe1975df9ad9b084a6195e","after":"4adb0e588e7a8b6397bc2b9038c6460be27d3501","ref":"refs/heads/bobertzh/v3Migration","pushedAt":"2024-09-28T16:03:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"HBobertz","name":"Hogan Bobertz","path":"/HBobertz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/18233297?s=80&v=4"},"commit":{"message":"make tests better","shortMessageHtmlLink":"make tests better"}},{"before":"099b45c02b768c5847c12d24cad34bc8635c7a04","after":"248b2c1368fbbc4bfefe1975df9ad9b084a6195e","ref":"refs/heads/bobertzh/v3Migration","pushedAt":"2024-09-28T15:32:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"HBobertz","name":"Hogan Bobertz","path":"/HBobertz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/18233297?s=80&v=4"},"commit":{"message":"update vpc tests","shortMessageHtmlLink":"update vpc tests"}},{"before":"ced4fb11eff02b1190bd9aae617adbad39bf5e05","after":"e2ad953b2d121ef4545bbc76aaa7e67ae6e1847c","ref":"refs/heads/test-main-pipeline","pushedAt":"2024-09-28T14:37:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-cdk-automation","name":"AWS CDK Automation","path":"/aws-cdk-automation","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43080478?s=80&v=4"},"commit":{"message":"Merge branch 'main' into epolon/notices-on-bootstrap-version","shortMessageHtmlLink":"Merge branch 'main' into epolon/notices-on-bootstrap-version"}},{"before":"d9f25ec60db273b073df365b8822f7e211df1b22","after":"e2ad953b2d121ef4545bbc76aaa7e67ae6e1847c","ref":"refs/heads/epolon/notices-on-bootstrap-version","pushedAt":"2024-09-28T14:36:23.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"iliapolo","name":"Eli Polonsky","path":"/iliapolo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1428812?s=80&v=4"},"commit":{"message":"Merge branch 'main' into epolon/notices-on-bootstrap-version","shortMessageHtmlLink":"Merge branch 'main' into epolon/notices-on-bootstrap-version"}},{"before":"4b00ffeb86b3ebb9a0190c2842bd36ebb4043f52","after":null,"ref":"refs/heads/2.158","pushedAt":"2024-09-28T13:24:31.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"iliapolo","name":"Eli Polonsky","path":"/iliapolo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1428812?s=80&v=4"}},{"before":"bdf1eef454ea4765e37ceef0e198f14e88a6f1a6","after":"5e08c981dd2a309c84abc01a0c8b358e55b5cc4c","ref":"refs/heads/main","pushedAt":"2024-09-27T23:46:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"feat(pipes-targets): add API destination (#30756)\n\nAdd EventBridge API destination as a Pipes target.\n\nCloudFormation groups EventBridge API destination with API Gateway REST API\nas [PipeTargetHttpParameters](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-pipes-pipe-pipetargethttpparameters.html#cfn-pipes-pipe-pipetargethttpparameters-pathparametervalues), but I think separating them here similar to [aws-event-targets](https://github.com/aws/aws-cdk/tree/main/packages/aws-cdk-lib/aws-events-targets/lib) \nmakes more sense, as API Gateway requires `stage`, `path`, and `method` (see [here](https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-events-targets/lib/api-gateway.ts#L11-L32)).","shortMessageHtmlLink":"feat(pipes-targets): add API destination (#30756)"}},{"before":"796e8d24402fea45b726ca068d2522f4a75a76ee","after":"71062e00b60850f24f9b547200bceea6b69f2898","ref":"refs/heads/conroy/gc","pushedAt":"2024-09-27T21:10:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"kaizencc","name":"Kaizen Conroy","path":"/kaizencc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36202692?s=80&v=4"},"commit":{"message":"parallel delete","shortMessageHtmlLink":"parallel delete"}},{"before":"54c01cbb24242f5646f2798f8b28ec6172dedbc9","after":"bdf1eef454ea4765e37ceef0e198f14e88a6f1a6","ref":"refs/heads/main","pushedAt":"2024-09-27T20:58:56.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(logs): fix for yarn build warning from log-group doc string (#31587)\n\n### Issue # (if applicable)\n\nN/A\n\n### Reason for this change\n- New warning following #31535 regarding the docstring\n\n### Description of changes\n- update params in the docstring to match the function declaration\n\n### Description of how you validated changes\n\n\n\n### Checklist\n- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"chore(logs): fix for yarn build warning from log-group doc string (#3…"}},{"before":"1de12fc737db8d9a41db211fdd3bae0061405a56","after":null,"ref":"refs/heads/s3-deploy-fix","pushedAt":"2024-09-27T18:10:48.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"}},{"before":"8318e7968c441ad565139e5faa72977a95099cd2","after":"54c01cbb24242f5646f2798f8b28ec6172dedbc9","ref":"refs/heads/main","pushedAt":"2024-09-27T18:10:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"feat(s3-deployment): added property outputObjectKeys for BucketDeployment (#31452)\n\n### Issue # (if applicable)\n\nCloses #28579\n\n### Reason for this change\n\nThe [CR lambda](https://github.com/aws/aws-cdk/blob/597228c1552a21f8dc7250a0be62160f838bb776/packages/%40aws-cdk/custom-resource-handlers/lib/aws-s3-deployment/bucket-deployment-handler/index.py#L138C14-L138C30) is essentially sending back the same data in the response which is hitting the limit for close to 50 object uploads.\n\nParticularly this is being a limitation when using servicecatalog.ProductStack, if there are local assets beyond a particular number, the Custom::CDKBucketDeployment would fail with the error Response object is too long which is a hard limit of 4096 bytes.\n\n### Description of changes\n\n1. Added a new property to control the custom resource sending large data and hitting the 4096 bytes limit even though the deployment operation is successful. \n2. The property `outputObjectKeys` has been set to false by default for the service catalog product so that the error does not occur. \n\n### Description of how you validated changes\n\nValidated using a sample stack with the property set and confirmed the behavior. Also, the existing deployments would be unaffected. \n\n### Checklist\n- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"feat(s3-deployment): added property outputObjectKeys for BucketDeploy…"}},{"before":"963cd5c227444531b593d97d8165496082ac8716","after":"1de12fc737db8d9a41db211fdd3bae0061405a56","ref":"refs/heads/s3-deploy-fix","pushedAt":"2024-09-27T17:40:03.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"Merge branch 'main' into s3-deploy-fix","shortMessageHtmlLink":"Merge branch 'main' into s3-deploy-fix"}},{"before":"636fbb2e3fb3907a38584039a116ec4e7b16a91b","after":"963cd5c227444531b593d97d8165496082ac8716","ref":"refs/heads/s3-deploy-fix","pushedAt":"2024-09-27T17:09:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"fixed comment message","shortMessageHtmlLink":"fixed comment message"}},{"before":"9f36afaa0eaf3b751bc9fea52cc43571da5f0b3f","after":"fa5da1984f6b2bfee8c079dc3574c23b7f29b859","ref":"refs/heads/comcalvi/order-dependent-logical-IDs","pushedAt":"2024-09-27T16:52:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"comcalvi","name":"Calvin Combs","path":"/comcalvi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/66279577?s=80&v=4"},"commit":{"message":"remove FF","shortMessageHtmlLink":"remove FF"}},{"before":"f6d023d15f38fa5b4c6491ee4a14a3ad8f2b352b","after":"3201024ef737c47258d07f2f18541d3bf5457b10","ref":"refs/heads/comcalvi/cfn-include-drops-stuff","pushedAt":"2024-09-27T16:01:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"comcalvi","name":"Calvin Combs","path":"/comcalvi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/66279577?s=80&v=4"},"commit":{"message":"yesyes","shortMessageHtmlLink":"yesyes"}},{"before":"75115403e2ea211b1242ccd90c93ea438efaa6c7","after":"9f36afaa0eaf3b751bc9fea52cc43571da5f0b3f","ref":"refs/heads/comcalvi/order-dependent-logical-IDs","pushedAt":"2024-09-27T15:58:35.000Z","pushType":"push","commitsCount":15,"pusher":{"login":"comcalvi","name":"Calvin Combs","path":"/comcalvi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/66279577?s=80&v=4"},"commit":{"message":"confclits","shortMessageHtmlLink":"confclits"}},{"before":"c7cee1525deb48d915740c9b30bdc6f886d17aa5","after":"8318e7968c441ad565139e5faa72977a95099cd2","ref":"refs/heads/main","pushedAt":"2024-09-27T14:49:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"chore(ecs): add integ test for ECS with Windows use case (#31545)\n\n### Issue # (if applicable)\n\nNone\n\n### Reason for this change\n\nAdding an integ test of using ECS with Windows AMIs. This is currently missing, hence, is a test gap.\n\n### Description of changes\n\nThe integ test creates an ECS cluster and a Ec2Service that lives in EC2 instances.\n\n### Description of how you validated changes\n\nN/A\n\n### Checklist\n- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"chore(ecs): add integ test for ECS with Windows use case (#31545)"}},{"before":"8fac1bb14d4f068e0ae72af28888d5f94ad9652d","after":"5039d454d953cc6383312d54214c83f17f8dfd0a","ref":"refs/heads/otaviom/cli-credentials-v3","pushedAt":"2024-09-27T14:17:47.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"otaviomacedo","name":"Otavio Macedo","path":"/otaviomacedo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/288203?s=80&v=4"},"commit":{"message":"Fixed more tests","shortMessageHtmlLink":"Fixed more tests"}},{"before":null,"after":"796e8d24402fea45b726ca068d2522f4a75a76ee","ref":"refs/heads/conroy/gc","pushedAt":"2024-09-27T13:20:00.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"kaizencc","name":"Kaizen Conroy","path":"/kaizencc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/36202692?s=80&v=4"},"commit":{"message":"tagging api in use now","shortMessageHtmlLink":"tagging api in use now"}},{"before":"8871e45f7b20a1bdc71075717986643e8326f744","after":"636fbb2e3fb3907a38584039a116ec4e7b16a91b","ref":"refs/heads/s3-deploy-fix","pushedAt":"2024-09-27T10:06:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"rerun the integration testing","shortMessageHtmlLink":"rerun the integration testing"}},{"before":"79d73df0ca9bf6a07b05a94eb7fe2991f085a509","after":"8871e45f7b20a1bdc71075717986643e8326f744","ref":"refs/heads/s3-deploy-fix","pushedAt":"2024-09-27T09:09:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"rerun the integration testing","shortMessageHtmlLink":"rerun the integration testing"}},{"before":"1d9670d735d3ee478ac6193ff85ebd23a5b94c41","after":"79d73df0ca9bf6a07b05a94eb7fe2991f085a509","ref":"refs/heads/s3-deploy-fix","pushedAt":"2024-09-27T08:24:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"rerun the integration testing","shortMessageHtmlLink":"rerun the integration testing"}},{"before":"52f676ca82a6078425020efcef73da8bd6afa261","after":"c7cee1525deb48d915740c9b30bdc6f886d17aa5","ref":"refs/heads/main","pushedAt":"2024-09-27T07:14:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"fix(appsync): lambda authorizer permission is not scoped to appsync api arn (#31567)\n\n### Issue # (if applicable)\n\nCloses #31550.\n\n### Reason for this change\n\nWhen using a lambda authorizer with a GraphqlAPI, the cdk automatically creates the AWS::Lambda::Permission required for the AppSync API to invoke the lambda authorizer. It does not however add a SourceArn.\n\nThis conflicts with the control tower policy [[CT.LAMBDA.PR.2]](https://docs.aws.amazon.com/controltower/latest/controlreference/lambda-rules.html#ct-lambda-pr-2-description), and it is in general good practice to scope permissions.\n\n### Description of changes\n\nAdded new feature flag `APPSYNC_GRAPHQLAPI_SCOPE_LAMBDA_FUNCTION_PERMISSION`.\n\nCurrently, when using a Lambda authorizer with an AppSync GraphQL API, the AWS CDK automatically generates the necessary AWS::Lambda::Permission to allow the AppSync API to invoke the Lambda authorizer. This permission is overly permissive because it lacks a SourceArn, meaning it allows invocations from any source.\n\nWhen this feature flag is enabled, the AWS::Lambda::Permission will be properly scoped with the SourceArn corresponding to the specific AppSync GraphQL API.\n```ts\n ...\n config?.handler.addPermission(`${id}-appsync`, {\n principal: new ServicePrincipal('appsync.amazonaws.com'),\n action: 'lambda:InvokeFunction',\n sourceArn: this.arn, // <-- added when feature flag is enabled\n });\n ...\n```\n\n### Description of how you validated changes\n\nUnit + integ tests with feature flag enabled. \n\n### Checklist\n- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"fix(appsync): lambda authorizer permission is not scoped to appsync a…"}},{"before":"6e5ffe28f1f13d4c65d083f906a467ea4c656688","after":"1d9670d735d3ee478ac6193ff85ebd23a5b94c41","ref":"refs/heads/s3-deploy-fix","pushedAt":"2024-09-27T05:11:02.000Z","pushType":"push","commitsCount":63,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"apply comments","shortMessageHtmlLink":"apply comments"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0zMFQwNjo0MDoxNy4wMDAwMDBazwAAAATEVgif","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yN1QwNToxMTowMi4wMDAwMDBazwAAAATCNqs5"}},"title":"Activity · aws/aws-cdk"}