Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification logic to validate the existance of cloudwatch loggroup #353

Open
Pixis-Akshay-Gopani opened this issue Sep 18, 2023 · 2 comments

Comments

@Pixis-Akshay-Gopani
Copy link

Pixis-Akshay-Gopani commented Sep 18, 2023

Description of issue:

it looks like this plugin is not verifying the existance of cloudwatch loggroup. This plugin should first verify the presence of loggroup. if loggroup does not exist then it should call the createloggroup api.

time="2023-09-15T11:25:35Z" level=info msg="[cloudwatch 0] Log group /aws/eks/test already exists\n"

@piotrgo
Copy link

piotrgo commented Sep 21, 2023

Hi @Pixis-Akshay-Gopani this plugin already has the functionality to create group if it doesn't exist
-p "auto_create_group=true"

Cheers

@Pixis-Akshay-Gopani
Copy link
Author

@piotrgo i know it has feature to auto create group. ideally it should first check the presence of loggroup. if loggroup does not exist then it should call createloggroup api. Based on fluentbit log i have found that fluentbit is not checking the presence of loggroup. it directly call the createloggroup api even if loggroup is already exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants