Not using OperationPreferences in StackSet resources in CFN

[horacix]

Describe the bug

The cloudformation template has parameters to configure operation preferences of the stacksets such as FailureTolerancePercentage and RegionConcurrencyType, but these paramaters are only used in the deployment manager Lambda and are not being used in the StackSet resources described in the same template. We manage hundreds of region/accounts, and stack updates take a long time and if only one region fails to update, the whole update fails and the CFN stack ends up in an invalid state.

To Reproduce

1. Deploy quota-monitor-hub.template in your org to an OU with more than one Stack Instances.
2. Update the stack, setting FailureTolerance or MaxConcurrent to a high number, and check that these parameters are not taken into account by the Update operation in the stackset.

Expected behavior

StackSet update operations should consider the Operation Preferences specified as parameters on the stack deployment.

Please complete the following information about the solution:

• [v6.3.0 ] Version: [e.g. v1.0.0]

To get the version of the solution, you can look at the description of the created CloudFormation stack. For example, "(SOXXXX) - The AWS CloudFormation template for deployment of the AWS Solution. Version vx.y.z". You can also find the version from releases

• Region: [e.g. us-east-1]
• Was the solution modified from the version published on this repository?
• If the answer to the previous question was yes, are the changes available on GitHub?
• Have you checked your service quotas for the services this solution uses?
• Were there any errors in the CloudWatch Logs? How to enable debug mode?

Screenshots
If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).

Additional context
I fixed this locally by adding the OperationPreferences attribute to the StackSet resources in the template, using the same values obtained from the Stack parameters. I can submit a PR with the change if you are interested.

[G-Lenz]

Thank you for bringing this to our attention. We will investigate this and add it to our backlog.