Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn tests into Jobs #4

Open
msolefonte opened this issue Mar 20, 2019 · 3 comments
Open

Turn tests into Jobs #4

msolefonte opened this issue Mar 20, 2019 · 3 comments

Comments

@msolefonte
Copy link

At least in the 1.4 Fabric version, tests and other only-one-use pods are deployed thought a deployment and not a job. I think it is better to have them as a job to limit resource usage once everything is deployed.

This is more a discussion than an actual issue, but can lead to some changes.

@MCLDG-zz
Copy link

Yes, makes sense. Would you like to submit a PR?

@msolefonte
Copy link
Author

I would like to, but I do not have an AWS account for testing usage and I do not want to spend any money in helping. However, I want to help.

If It is useful, I can try to modify deployment files but they have to be tested by another one. I actually have a lot of things in mind to be changed/improved which I am going to turn into issues/pr as long as I have time for it.

@msolefonte
Copy link
Author

There is already a PR. I have been trying to modify also the /k8s-templates/fabric-deployment-register* YAML files to turn them into jobs, but the script also has to be modified. The problem here is that when the peer/org/orderer has already been registered, the script returns an error, which is interpreted as a fatal error by Kubernetes (setting the job status as Error).

To solve this, I recommend to not return an error but a warning in the script, and end the execution with a 0 status. However, this is very different from this issue, so should be debated in another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants