Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the feature to not use the suffix when create the topic #3

Open
hiroarabay opened this issue Jul 31, 2023 · 4 comments
Open

add the feature to not use the suffix when create the topic #3

hiroarabay opened this issue Jul 31, 2023 · 4 comments

Comments

@hiroarabay
Copy link

Background

We don't want to use the suffix when create the topics.

Feature

  • Create 'use-suffix' config. true for using suffix and false for not using suffix.
  • Default value is false.
  • handling "TopicAlreadyExists" error
@hiroarabay
Copy link
Author

@buddhike
what do you think about it ? : )

@buddhike
Copy link
Contributor

buddhike commented Aug 8, 2023

Hi @hiroarabay,

Thank you so much for checking out this project and suggesting this improvement 🙏.

Without the suffix, we would need a safe mechanism to handle delete-stack operation (i.e. we should not delete the topic or users in Secrets Manager if they are not created by the current stack). Have you thought about a good approach to handle this?

@buddhike buddhike added enhancement New feature or request and removed enhancement New feature or request labels Aug 8, 2023
@hiroarabay
Copy link
Author

@buddhike
Thank you for your reply.
You are concerned about the possibility that a topic created in stack 1 will be deleted in stack 2(another stack), right?
We can avoid it by below:

  • Set delete.topic.enable in Broker config of MSK to false
  • Do not manage them in a stack different from the created stack
  • Cancel the stack because you are trying to create it with the existing name

handling "TopicAlreadyExists" error

@man-jiteshm-sportsbet
Copy link

man-jiteshm-sportsbet commented Jan 17, 2024

would like this too as we want to migrate an existing cluster and use the same topic names on the new MSK cluster. dont like the idea of random suffixes being added to a topic name. If you can provide some insights on what changes would be required, happy to fork it and create our own version locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants