diff --git a/.github/scripts/mkdocs-hooks.py b/.github/scripts/mkdocs-hooks.py index bfa513aa87..e7cd522642 100644 --- a/.github/scripts/mkdocs-hooks.py +++ b/.github/scripts/mkdocs-hooks.py @@ -10,23 +10,36 @@ def on_page_markdown(markdown, **kwargs): def on_files(files, config, **kwargs): # Add targeted-odcr screenshots to the generated build + path = 'patterns/targeted-odcr/assets/' for odcr_file in [1, 2]: files.append( File( - src_dir='./patterns/targeted-odcr/assets/', - dest_dir=os.path.join(config.site_dir, 'patterns/targeted-odcr/assets/'), + src_dir=f'./{path}', + dest_dir=os.path.join(config.site_dir, path), path=f'odcr-screenshot{odcr_file}.png', use_directory_urls=True ) ) + path = 'patterns/kubecost/assets/' files.append( File( - src_dir='./patterns/kubecost/assets/', - dest_dir=os.path.join(config.site_dir, 'patterns/kubecost/assets/'), + src_dir=f'./{path}', + dest_dir=os.path.join(config.site_dir, path), path='screenshot.png', use_directory_urls=True ) ) + for svg in ['cached.svg', 'uncached.svg', 'state-machine.png']: + files.append( + File( + src_dir=f'./patterns/ml-container-cache/assets/', + dest_dir=os.path.join(config.site_dir, 'patterns/machine-learning/ml-container-cache/assets/'), + path=svg, + use_directory_urls=True + ) + ) + + return files diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index ce0672a77d..e1e2c75667 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -11,9 +11,9 @@ on: env: TERRAFORM_VERSION: 1.3.10 - TERRAFORM_DOCS_VERSION: v0.16.0 + TERRAFORM_DOCS_VERSION: v0.19.0 + TFLINT_VERSION: v0.53.0 TF_PLUGIN_CACHE_DIR: ${{ github.workspace }}/.terraform.d/plugin-cache - TFLINT_VERSION: v0.50.2 concurrency: group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}' diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 024afe9fa7..3579cf011e 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -19,7 +19,7 @@ repos: - id: detect-aws-credentials args: [--allow-missing-credentials] - repo: https://github.com/antonbabenko/pre-commit-terraform - rev: v1.92.1 + rev: v1.96.1 hooks: - id: terraform_fmt - id: terraform_docs diff --git a/docs/patterns/machine-learning/ml-container-cache.md b/docs/patterns/machine-learning/ml-container-cache.md new file mode 100644 index 0000000000..6c6fa8cc94 --- /dev/null +++ b/docs/patterns/machine-learning/ml-container-cache.md @@ -0,0 +1,7 @@ +--- +title: ML Container Cache +--- + +{% + include-markdown "../../../patterns/ml-container-cache/README.md" +%} diff --git a/patterns/ml-container-cache/README.md b/patterns/ml-container-cache/README.md new file mode 100644 index 0000000000..25fb37fd60 --- /dev/null +++ b/patterns/ml-container-cache/README.md @@ -0,0 +1,105 @@ +# EKS Cluster w/ Cached ML Images + +This pattern demonstrates how to cache images on an EBS volume snapshot that will be used by nodes in an EKS cluster. The solution is comprised of primarily of the following components: + +1. An AWS Step Function implementation has been provided that demonstrates an example process for creating EBS volume snapshots that are pre-populated with the select container images. As part of this process, EBS Fast Snapshot Restore is enabled by default for the snapshots created to avoid the [EBS volume initialization time penalty](https://aws.amazon.com/blogs/storage/addressing-i-o-latency-when-restoring-amazon-ebs-volumes-from-ebs-snapshots/). The Step Function state machine diagram is captured below for reference. +2. The node group demonstrates how to mount the generated EBS volume snapshot at the `/var/lib/containerd` location in order for containerd to utilize the pre-populated images. The snapshot ID is referenced via an SSM parameter data source which was populated by the Step Function cache builder; any new images created by the cache builder will automatically update the SSM parameter used by the node group. + +The main benefit of caching, or pre-pulling, container images onto an EBS volume snapshot is faster time to start pods/containers on new nodes, especially for larger (multi-gigabyte) images that are common with machine-learning workloads. This process avoids the time and resources it takes to pull and un-pack container images from remote registries. Instead, those images are already present in the location that containerd expects, allowing for faster pod startup times. + +### Cache Builder State Machine + +

+ cached builder state machine +

+ +## Results + +The following results use the PyTorch [nvcr.io/nvidia/pytorch:24.08-py3](https://catalog.ngc.nvidia.com/orgs/nvidia/containers/pytorch/tags) image which is 9.5 GB compressed and 20.4 GB decompressed on disk. + +Pod start up time duration is captured via pod events using [ktime](https://github.com/clowdhaus/ktime). + +### Cached + +With the PyTorch image already present on the EBS volume, the pod starts up in less than 5 seconds: + +

+ cached image startup time +

+ +### Uncached + +When the PyTorch image is not present on the EBS volume, it takes roughly 6 minutes (334 seconds in the capture below) for the image to be pulled, unpacked, and the pod to start. + +

+ uncached image startup time +

+ +## Code + +### Cache Builder + +```terraform hl_lines="7-11 13-14" +{% include "../../patterns/ml-container-cache/cache_builder.tf" %} +``` + +### Cluster + +```terraform hl_lines="5-9 52-64 66-78" +{% include "../../patterns/ml-container-cache/eks.tf" %} +``` + +## Deploy + +See [here](https://aws-ia.github.io/terraform-aws-eks-blueprints/getting-started/#prerequisites) for the prerequisites and steps to deploy this pattern. + +1. First, deploy the Step Function state machine that will create the EBS volume snapshots with the cached images. + + ```sh + terraform init + terraform apply -target=module.ebs_snapshot_builder -target=module.vpc --auto-approve + ``` + +2. Once the cache builder resources have been provisioned, execute the state machine by either navigating to the state machine within the AWS console and clicking `Start execution` (with the defaults or by passing in values to override the default values), or by using the provided output from the Terraform output value `start_execution_command` to start the state machine using the awscli. For example, the output looks similar to the following: + + ```hcl + start_execution_command = <bbiggs%bbiggs%ktimebbiggs%ktimeapplybbiggs%ktimeapply--filebbiggs%ktimeapply--filepod-cached.yamlINFOktime::cli:Pod`cached`appliedINFOktime::cli:Pod`cached`=>RunningInitialize:0sPodreadytostartcontainers:2sContainersready:2sReady:2sbbiggs%exitbbiggs%kbbiggs%ktbbiggs%ktibbiggs%ktimbbiggs%ktimeabbiggs%ktimeapbbiggs%ktimeappbbiggs%ktimeapplbbiggs%ktimeapply-bbiggs%ktimeapply--bbiggs%ktimeapply--fbbiggs%ktimeapply--fibbiggs%ktimeapply--filbbiggs%ktimeapply--filepbbiggs%ktimeapply--filepobbiggs%ktimeapply--filepodbbiggs%ktimeapply--filepod-bbiggs%ktimeapply--filepod-cbbiggs%ktimeapply--filepod-cabbiggs%ktimeapply--filepod-cacbbiggs%ktimeapply--filepod-cachbbiggs%ktimeapply--filepod-cachebbiggs%ktimeapply--filepod-cachedbbiggs%ktimeapply--filepod-cached.bbiggs%ktimeapply--filepod-cached.ybbiggs%ktimeapply--filepod-cached.yabbiggs%ktimeapply--filepod-cached.yambbiggs%ebbiggs%exbbiggs%exi diff --git a/patterns/ml-container-cache/assets/state-machine.png b/patterns/ml-container-cache/assets/state-machine.png new file mode 100644 index 0000000000..9a2af3ec9a Binary files /dev/null and b/patterns/ml-container-cache/assets/state-machine.png differ diff --git a/patterns/ml-container-cache/assets/uncached.svg b/patterns/ml-container-cache/assets/uncached.svg new file mode 100644 index 0000000000..8df69b05bd --- /dev/null +++ b/patterns/ml-container-cache/assets/uncached.svg @@ -0,0 +1 @@ +bbiggs%bbiggs%ktimebbiggs%ktimeapplybbiggs%ktimeapply--filebbiggs%ktimeapply--filepod-uncached.yamlINFOktime::cli:Pod`uncached`appliedINFOktime::cli:Waitingforpod`uncached`tobeinthe`Running`phase...INFOktime::cli:Pod`uncached`=>RunningInitialize:0sPodreadytostartcontainers:334sContainersready:334sReady:334sbbiggs%exitbbiggs%kbbiggs%ktbbiggs%ktibbiggs%ktimbbiggs%ktimeabbiggs%ktimeapbbiggs%ktimeappbbiggs%ktimeapplbbiggs%ktimeapply-bbiggs%ktimeapply--bbiggs%ktimeapply--fbbiggs%ktimeapply--fibbiggs%ktimeapply--filbbiggs%ktimeapply--filepbbiggs%ktimeapply--filepobbiggs%ktimeapply--filepodbbiggs%ktimeapply--filepod-bbiggs%ktimeapply--filepod-ubbiggs%ktimeapply--filepod-unbbiggs%ktimeapply--filepod-uncbbiggs%ktimeapply--filepod-uncabbiggs%ktimeapply--filepod-uncacbbiggs%ktimeapply--filepod-uncachbbiggs%ktimeapply--filepod-uncachebbiggs%ktimeapply--filepod-uncachedbbiggs%ktimeapply--filepod-uncached.bbiggs%ktimeapply--filepod-uncached.ybbiggs%ktimeapply--filepod-uncached.yabbiggs%ktimeapply--filepod-uncached.yambbiggs%ebbiggs%exbbiggs%exi diff --git a/patterns/ml-container-cache/cache_builder.tf b/patterns/ml-container-cache/cache_builder.tf new file mode 100644 index 0000000000..4fb7c777d6 --- /dev/null +++ b/patterns/ml-container-cache/cache_builder.tf @@ -0,0 +1,20 @@ +module "ebs_snapshot_builder" { + source = "clowdhaus/ebs-snapshot-builder/aws" + version = "~> 1.1" + + name = local.name + + # Images to cache + public_images = [ + "nvcr.io/nvidia/k8s-device-plugin:v0.16.2", # 120 MB compressed / 351 MB decompressed + "nvcr.io/nvidia/pytorch:24.08-py3", # 9.5 GB compressed / 20.4 GB decompressed + ] + + # AZs where EBS fast snapshot restore will be enabled + fsr_availability_zone_names = local.azs + + vpc_id = module.vpc.vpc_id + subnet_id = element(module.vpc.private_subnets, 0) + + tags = local.tags +} diff --git a/patterns/ml-container-cache/eks.tf b/patterns/ml-container-cache/eks.tf new file mode 100644 index 0000000000..75e4cff1d3 --- /dev/null +++ b/patterns/ml-container-cache/eks.tf @@ -0,0 +1,118 @@ +locals { + dev_name = "xvdb" +} + +# SSM parameter where the `cache-builder` stores the generated snapshot ID +# This will be used to reference the snapshot when creating the EKS node group +data "aws_ssm_parameter" "snapshot_id" { + name = module.ebs_snapshot_builder.ssm_parameter_name +} + +################################################################################ +# Cluster +################################################################################ + +module "eks" { + source = "terraform-aws-modules/eks/aws" + version = "~> 20.24" + + cluster_name = local.name + cluster_version = "1.31" + + # Give the Terraform identity admin access to the cluster + # which will allow it to deploy resources into the cluster + enable_cluster_creator_admin_permissions = true + cluster_endpoint_public_access = true + + cluster_addons = { + coredns = {} + eks-pod-identity-agent = {} + kube-proxy = {} + vpc-cni = {} + } + + vpc_id = module.vpc.vpc_id + subnet_ids = module.vpc.private_subnets + + eks_managed_node_group_defaults = { + ebs_optimized = true + } + + eks_managed_node_groups = { + gpu = { + # The EKS AL2 GPU AMI provides all of the necessary components + # for accelerated workloads w/ EFA + ami_type = "AL2_x86_64_GPU" + instance_types = ["g6e.xlarge"] + + min_size = 1 + max_size = 1 + desired_size = 1 + + pre_bootstrap_user_data = <<-EOT + # Mount the second volume for containerd persistent data + # This volume contains the cached images and layers + + systemctl stop containerd kubelet + + rm -rf /var/lib/containerd/* + echo '/dev/${local.dev_name} /var/lib/containerd xfs defaults 0 0' >> /etc/fstab + mount -a + + systemctl restart containerd kubelet + + EOT + + # Mount a second volume for containerd persistent data + # using the snapshot that contains the cached images and layers + block_device_mappings = { + (local.dev_name) = { + device_name = "/dev/${local.dev_name}" + ebs = { + # Snapshot ID from the cache builder + snapshot_id = nonsensitive(data.aws_ssm_parameter.snapshot_id.value) + volume_size = 64 + volume_type = "gp3" + } + } + } + + labels = { + "nvidia.com/gpu.present" = "true" + "ml-container-cache" = "true" + } + + taints = { + # Ensure only GPU workloads are scheduled on this node group + gpu = { + key = "nvidia.com/gpu" + value = "true" + effect = "NO_SCHEDULE" + } + } + } + + # This node group is for core addons such as CoreDNS + default = { + instance_types = ["m5.large"] + + min_size = 1 + max_size = 2 + desired_size = 2 + + # Not required - increased to demonstrate pulling the un-cached + # image since the default volume size is too small for the image used + block_device_mappings = { + "xvda" = { + device_name = "/dev/xvda" + ebs = { + volume_size = 64 + volume_type = "gp3" + } + } + } + } + } + + tags = local.tags +} diff --git a/patterns/ml-container-cache/helm.tf b/patterns/ml-container-cache/helm.tf new file mode 100644 index 0000000000..cd1d65858c --- /dev/null +++ b/patterns/ml-container-cache/helm.tf @@ -0,0 +1,27 @@ +################################################################################ +# Helm charts +################################################################################ + +resource "helm_release" "nvidia_device_plugin" { + name = "nvidia-device-plugin" + repository = "https://nvidia.github.io/k8s-device-plugin" + chart = "nvidia-device-plugin" + version = "0.16.2" # Matches image that is cached + namespace = "nvidia-device-plugin" + create_namespace = true + wait = false + + values = [ + <<-EOT + affinity: + nodeAffinity: + requiredDuringSchedulingIgnoredDuringExecution: + nodeSelectorTerms: + - matchExpressions: + - key: 'nvidia.com/gpu.present' + operator: In + values: + - 'true' + EOT + ] +} diff --git a/patterns/ml-container-cache/main.tf b/patterns/ml-container-cache/main.tf new file mode 100644 index 0000000000..497b3837b6 --- /dev/null +++ b/patterns/ml-container-cache/main.tf @@ -0,0 +1,102 @@ +terraform { + required_version = ">= 1.3" + + required_providers { + aws = { + source = "hashicorp/aws" + version = ">= 5.34" + } + helm = { + source = "hashicorp/helm" + version = ">= 2.9" + } + } + + # ## Used for end-to-end testing on project; update to suit your needs + # backend "s3" { + # bucket = "terraform-ssp-github-actions-state" + # region = "us-west-2" + # key = "e2e/ml-container-cache/terraform.tfstate" + # } +} + +provider "aws" { + region = local.region +} + +provider "helm" { + kubernetes { + host = module.eks.cluster_endpoint + cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data) + + exec { + api_version = "client.authentication.k8s.io/v1beta1" + command = "aws" + # This requires the awscli to be installed locally where Terraform is executed + args = ["eks", "get-token", "--cluster-name", module.eks.cluster_name] + } + } +} + +################################################################################ +# Common data/locals +################################################################################ + +data "aws_availability_zones" "available" { + # Do not include local zones + filter { + name = "opt-in-status" + values = ["opt-in-not-required"] + } +} + +locals { + name = basename(path.cwd) + region = "us-west-2" + + vpc_cidr = "10.0.0.0/16" + azs = slice(data.aws_availability_zones.available.names, 0, 3) + + tags = { + Blueprint = local.name + GithubRepo = "github.com/aws-ia/terraform-aws-eks-blueprints" + } +} + +################################################################################ +# Output +################################################################################ + +output "configure_kubectl" { + description = "Configure kubectl: make sure you're logged in with the correct AWS profile and run the following command to update your kubeconfig" + value = "aws eks --region ${local.region} update-kubeconfig --name ${module.eks.cluster_name}" +} + +################################################################################ +# Supporting Resources +################################################################################ + +module "vpc" { + source = "terraform-aws-modules/vpc/aws" + version = "~> 5.0" + + name = local.name + cidr = local.vpc_cidr + + azs = local.azs + private_subnets = [for k, v in local.azs : cidrsubnet(local.vpc_cidr, 4, k)] + public_subnets = [for k, v in local.azs : cidrsubnet(local.vpc_cidr, 8, k + 48)] + + enable_nat_gateway = true + single_nat_gateway = true + + public_subnet_tags = { + "kubernetes.io/role/elb" = 1 + } + + private_subnet_tags = { + "kubernetes.io/role/internal-elb" = 1 + } + + tags = local.tags +} diff --git a/patterns/ml-container-cache/pod-cached.yaml b/patterns/ml-container-cache/pod-cached.yaml new file mode 100644 index 0000000000..1464249549 --- /dev/null +++ b/patterns/ml-container-cache/pod-cached.yaml @@ -0,0 +1,20 @@ +apiVersion: v1 +kind: Pod +metadata: + name: cached +spec: + containers: + - name: example + image: nvcr.io/nvidia/pytorch:24.08-py3 + imagePullPolicy: IfNotPresent + command: ['python3'] + args: ['-c', 'import torch; print(torch.cuda.is_available()); print(torch.cuda.device_count())'] + resources: + limits: + nvidia.com/gpu: '1' + nodeSelector: + ml-container-cache: 'true' + tolerations: + - key: 'nvidia.com/gpu' + operator: 'Exists' + effect: 'NoSchedule' diff --git a/patterns/ml-container-cache/pod-uncached.yaml b/patterns/ml-container-cache/pod-uncached.yaml new file mode 100644 index 0000000000..4c450a63d5 --- /dev/null +++ b/patterns/ml-container-cache/pod-uncached.yaml @@ -0,0 +1,11 @@ +apiVersion: v1 +kind: Pod +metadata: + name: uncached +spec: + containers: + - name: example + image: nvcr.io/nvidia/pytorch:24.08-py3 + imagePullPolicy: IfNotPresent + command: ['python3'] + args: ['-c', 'import torch; print(torch.cuda.is_available()); print(torch.cuda.device_count())']