Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for aws-fsx-openzfs-csi-driver #352

Open
mirajranpura opened this issue Feb 7, 2024 · 4 comments
Open

Enable support for aws-fsx-openzfs-csi-driver #352

mirajranpura opened this issue Feb 7, 2024 · 4 comments
Labels
add-on enhancement New feature or request

Comments

@mirajranpura
Copy link

mirajranpura commented Feb 7, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?

EKS blueprints should natively support the Amazon FSx for OpenZFS CSI Driver

Describe the solution you would like

EKS blueprints should have OpenZFS CSI driver flag just like Amazon FSx for Lustre CSI Driver have enable_aws_fsx_csi_driver = true which installs the CSI drivers for Lustre.

Apparently, one can't bootstrap the EKS cluster with OpenZFS CSI driver.

Describe alternatives you have considered

Manually installing helm chart for Amazon FSx for OpenZFS CSI Driver

@askulkarni2 askulkarni2 added enhancement New feature or request add-on labels Feb 8, 2024
@joaocc
Copy link
Contributor

joaocc commented Apr 2, 2024

Is this open for inclusion via contributed PR? Or the inclusion is still something that needs to be decided?

@askulkarni2
Copy link
Contributor

askulkarni2 commented Apr 4, 2024

@joaocc yes we are happy to accept a PR! Thanks for working on this!

@joaocc
Copy link
Contributor

joaocc commented Apr 4, 2024

Great. I will need some assistance on deciding what would be reasonable defaults and on specifics of xFS.
I was trying to decide whether to "emulate" the approach by EFS-CSI, where it uses explicitly defined policies, but I don't know enough about xFS to be able to do anything else than copying the content of the managed policy.
On the other hand, to use the recommended approach of the managed policy (as per aws-ia/terraform-aws-eks-blueprints-addon#28) it seems we would have to resort to creating the resource and policy assignment in this project (vs doing it on the addonside of things).
Any thoughts welcomed.

@joaocc joaocc mentioned this issue May 8, 2024
3 tasks
@joaocc
Copy link
Contributor

joaocc commented May 8, 2024

Hi. Draft PR ready for feedback (not yet tested as I wanted to know which of the IAM approaches to follow). Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-on enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants