Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(Authenticator): Clicking the Sign in tab when already on the Sign In tab opens the #5911

Open
4 tasks done
hbuchel opened this issue Oct 16, 2024 · 1 comment · May be fixed by #5912
Open
4 tasks done

Bug(Authenticator): Clicking the Sign in tab when already on the Sign In tab opens the #5911

hbuchel opened this issue Oct 16, 2024 · 1 comment · May be fixed by #5912
Labels
Authenticator An issue or a feature-request for an Authenticator UI Component bug Something isn't working pending-maintainer-response Issue is pending response from an Amplify UI maintainer

Comments

@hbuchel
Copy link
Contributor

hbuchel commented Oct 16, 2024

Before creating a new issue, please confirm:

On which framework/platform are you having an issue?

React

Which UI component?

Authenticator

How is your app built?

Next.js

What browsers are you seeing the problem on?

No response

Which region are you seeing the problem in?

No response

Please describe your bug.

In the Authenticator component, if you click on the tab that is currently active, it switches the active tab.

What's the expected behaviour?

Clicking the active tab button should not switch the active tab to the other.

Help us reproduce the bug!

In the example on https://ui.docs.amplify.aws/react/connected-components/authenticator, with the "Sign in" tab open, click the "Sign in" tab again and it switches the active tab to Create Account.

Code Snippet

// Put your code below this line.

Console log output

No response

Additional information and screenshots

No response

@github-actions github-actions bot added pending-triage Issue is pending triage pending-maintainer-response Issue is pending response from an Amplify UI maintainer labels Oct 16, 2024
@hbuchel hbuchel added bug Something isn't working Authenticator An issue or a feature-request for an Authenticator UI Component and removed pending-triage Issue is pending triage pending-maintainer-response Issue is pending response from an Amplify UI maintainer labels Oct 16, 2024
@hbuchel hbuchel linked a pull request Oct 16, 2024 that will close this issue
5 tasks
@mjdepalma
Copy link

mjdepalma commented Oct 16, 2024

Some extra context in case it helps. Selecting a particular page title should (1) switch to that page if user focus is currently on opposite page (which works), and (2) stay on that page if user is already on that page (which doesn't work). That is the way all menus and spreadsheet pages work, and is the way that users will expect it to work as well.

(1) With focus on Sign In page, select "Sign In", and focus will incorrectly toggle to "Create Account"
(2) select "Sign In" again, and focus will toggle back to "Sign In"
(3) you can repeat steps 1 & 2 over and over to see the issue
(4) with focus on Create Account page, select "Create Account" page title, and focus will incorrectly toggle to "Sign In"
(5) select "Create Account" again, and focus will toggle back to "Create Account"
(6) you can repeat steps 4 & 5 over and over to see the issue

Hope this helps!

@github-actions github-actions bot added the pending-maintainer-response Issue is pending response from an Amplify UI maintainer label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Authenticator An issue or a feature-request for an Authenticator UI Component bug Something isn't working pending-maintainer-response Issue is pending response from an Amplify UI maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants