Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Authenticator): Adding new error localizations for limits exceeded #96

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

ruisebas
Copy link
Member

Issue #, if available:

Description of changes:

This PR adds new localization entries for the following errors coming from Cognito:

  • LimitExceededException, mapped to a AWSCognitoAuthError.limitExceeded by Amplify
  • NotAuthorizedException with a message of "Password attempts exceeded", mapped to a AuthError.notAuthorized by Amplify.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ruisebas ruisebas requested review from a team as code owners September 20, 2024 16:20
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.81%. Comparing base (068bd3c) to head (ba11613).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   41.69%   41.81%   +0.12%     
==========================================
  Files          41       41              
  Lines        1902     1906       +4     
==========================================
+ Hits          793      797       +4     
  Misses       1109     1109              
Flag Coverage Δ
Authenticator 41.81% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

harsh62
harsh62 previously approved these changes Sep 20, 2024
@ruisebas ruisebas force-pushed the ruisebas/adding_additional_errors branch from 8dc28e8 to 7ac4405 Compare September 20, 2024 18:27
@ruisebas ruisebas merged commit 1ec95fb into main Sep 20, 2024
3 checks passed
@ruisebas ruisebas deleted the ruisebas/adding_additional_errors branch September 20, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants