Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address failures that break telemetry #2010

Open
rtpascual opened this issue Sep 16, 2024 · 0 comments
Open

Address failures that break telemetry #2010

rtpascual opened this issue Sep 16, 2024 · 0 comments
Labels
tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later

Comments

@rtpascual
Copy link
Contributor

rtpascual commented Sep 16, 2024 •
edited
Loading

Describe the bug

In the scenario when failures happen before the CLI gets to send telemetry, we are unable to figure out impact.

A suggestion may be to dynamically import yargs and lift it up in order to have these types of failures go through our error handling.

See https://github.com/aws-amplify/amplify-backend/actions/runs/10876578911/job/30176690831#step:6:1133 for an example of an error that happened when loading CLI before it runs a command.
@rtpascual rtpascual added the pending-triage Incoming issues that need categorization label Sep 16, 2024
@josefaidt josefaidt added tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later and removed pending-triage Incoming issues that need categorization labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt Refactors, unsavory workarounds or other technical decisions that should be revisited later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josefaidt @rtpascual