Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apollo): Add details about authorization modes to Apollo AppSync README #2912

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Adds some additional details around authorization modes to the apollo/README file.

How did you test these changes?
n/a

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner September 9, 2024 13:59
@mattcreaser mattcreaser force-pushed the mattcreaser/apollo-readme-update branch from 7b3ac14 to fd3aff1 Compare September 9, 2024 14:01
@mattcreaser mattcreaser force-pushed the mattcreaser/apollo-readme-update branch from fd3aff1 to 212c8fe Compare September 9, 2024 14:01
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.03%. Comparing base (7f874ed) to head (b493020).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2912      +/-   ##
==========================================
+ Coverage   44.01%   44.03%   +0.01%     
==========================================
  Files         926      931       +5     
  Lines       30485    30688     +203     
  Branches     4351     4496     +145     
==========================================
+ Hits        13419    13512      +93     
- Misses      15601    15693      +92     
- Partials     1465     1483      +18     

@mattcreaser mattcreaser enabled auto-merge (squash) September 20, 2024 15:46
@mattcreaser mattcreaser merged commit 55bc64e into main Sep 23, 2024
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/apollo-readme-update branch September 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants