Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable update interval and backoff #76

Open
vililahtevanoja-solibri opened this issue Sep 29, 2021 · 3 comments
Open

Allow configurable update interval and backoff #76

vililahtevanoja-solibri opened this issue Sep 29, 2021 · 3 comments

Comments

@vililahtevanoja-solibri

In #28 an issue was encountered with exceeding API rate limits. This was attended to with PR #29 where the update query interval was increased to 30s, and handling was added for rate exceeded error.

30s interval also has the effect of adding a 0-30s overhead to each action, depending on when the CodeBuild job happens to complete. For some use cases this overhead can be quite noticeable and unnecessary. E.g. for a singular/small group of short CodeBuild build(s), where we have little danger of hitting the rate-limiting. Some use-cases may also involve running CodeBuild builds in sequence, where this overhead is multiplied by the number of sequenced builds.

Offering a way to configure the update interval and backoff, rather than have them hard-coded as they are now, allows for a more fine-grained way to tune the API call rate to fit the use-case. This makes it possible to limit the unnecessary time overhead involved and enable a faster turn-around time. The current values could be kept as default.

@DrewCurd
Copy link

Is there anymore news on this one if configurable interval and backoff is in the future?

@vililahtevanoja
Copy link
Contributor

vililahtevanoja commented Jan 25, 2023

Is there anymore news on this one if configurable interval and backoff is in the future?

The CI run for #76 was approved after I had already moved on from a client, so I didn't see what happened with the CI run and do not have access to that account anymore. Apparently there was some error in the run but alas those logs are long lost now. The codebase has seen very few changes so I created #77 with the same changes on top of the current master-branch here. Hoping that it will chug along a bit more swimmingly 🤞🏻

@vililahtevanoja
Copy link
Contributor

This can be closed, as the implementation was merged in #116 and released with v1.0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants