-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Remove dependency on docker client #598
Labels
feature-request
A feature should be added or improved.
Comments
Same here, have a version v2. |
I am more than happy to offer a Pull Request if the team approves this proposal |
I think this would also solve #434 ? |
Yes it would |
@runlevel5 is there a workaround for this? I tried using another runner but then |
AFAIK the answer is no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From my understanding in order to perform authentication, the action utilises the
docker
client to performdocker login
. Which is fine. However this dependency will make this plugin incompatible with environment that does not ship docker client (or users could not install any software). IMHO the action should take advantage of the HTTP API endpoint to perform this task instead.One example I run into is that I run gitub action runners on AWS Lambda & ECS & ECS Fargate environment which lacks the docker CLI. The error output I got is:
The text was updated successfully, but these errors were encountered: