Skip to content
This repository has been archived by the owner on Aug 14, 2023. It is now read-only.

Issues with SimpleMap and WPML compatibility #188

Open
wpsmort opened this issue Mar 8, 2017 · 4 comments
Open

Issues with SimpleMap and WPML compatibility #188

wpsmort opened this issue Mar 8, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@wpsmort
Copy link

wpsmort commented Mar 8, 2017

Vuk from WPML tested the latest version of SimpleMap (v2.5) and found compatibility issues with WPML as follows:

I've updated your plugin and tested it.

It is not listing anymore locations from all languages, but now it is not listing location in proper language, please take a look at here: http://plugin-simplemap.compatibility.wpml.org/sr/test-page/

In previous version, on every language all language locations were shown.

Now only one is shown which is ok because we have only one, but it should be seen in right language.

@wpsmort wpsmort self-assigned this Mar 8, 2017
@wpsmort
Copy link
Author

wpsmort commented Mar 8, 2017

I have asked Vuk to give us access to their test site so we can see how WPML and SimpleMap are configured. This will make it easier to reproduce the issue locally.

@wpsmort
Copy link
Author

wpsmort commented Mar 21, 2017

I tested further and the problem is that on translated pages we're not displaying the correct locations. We only output the default language locations.

For example, if you have a site with English and French content and you create WPML translations for your locations for both languages then on both the English and French map pages we only output English language locations.

What should happen is that on the English language page we output all English language locations, and on the French language page we output all the French language locations.

I tested back to version 2.4.7 and this has never worked.

@wpsmort wpsmort assigned amostajo and unassigned wpsmort Mar 21, 2017
@wpsmort wpsmort added the Bug label Mar 21, 2017
@wpsmort wpsmort modified the milestones: 2.5.1, 2.6 Mar 22, 2017
@wpsmort wpsmort self-assigned this May 11, 2017
@wpsmort
Copy link
Author

wpsmort commented May 11, 2017

#79 may have fixed this. I will perform more testing to confirm.

@wpsmort
Copy link
Author

wpsmort commented May 12, 2017

I have confirmed that PR #244 fixes this issue. I'm leaving this open until we have a beta with this fix in it so I can send it to WPMl for them to confirm the fix.

@michaeltorbert michaeltorbert modified the milestones: 2.6, 2.7 Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants