From b567eba324bf7035888b6ed80f4772a070229177 Mon Sep 17 00:00:00 2001
From: Pierre Awaragi <pierre@awaragi.com>
Date: Tue, 16 Apr 2024 13:31:49 -0400
Subject: [PATCH] added request timeout and request socket timeout options
 (default undefined)

---
 README.md                             |  6 +++++-
 lib/eleventy-plugin-plantuml.js       |  7 +++++-
 test/eleventy-plugin-plantuml.test.js | 31 +++++++++++++++++++++++++++
 3 files changed, 42 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 4b9a56c..9850904 100644
--- a/README.md
+++ b/README.md
@@ -34,7 +34,9 @@ eleventyConfig.addPlugin(plantuml.plugin, {
   port: 8888,
   prefix: "",
   outputType: "svg",
-  imgClass: "plantuml",
+  imgClass: "plantuml", 
+  requestTimeout: undefined, // undefined or millisecondes
+  requestSocketTimeout: undefined, // undefined or millisecondes
 });
 ```
 
@@ -42,6 +44,8 @@ If the server options are omitted, the plugin defaults to <http://plantuml.com/p
 
 By default the generated img tag will have class **plantuml** assigned to it. This can be overridden using options.imgClass value.
 
+Timeout options are passed directly to the underlying request object. See https://www.npmjs.com/package/sync-request. They default to sync-request
+
 ## Using in templates
 
 Simply create a markdown code block of type plantuml. It will be replaced by an img with inline png src (dataurl), or with svg code, depending on the value of the option `outputType`.
diff --git a/lib/eleventy-plugin-plantuml.js b/lib/eleventy-plugin-plantuml.js
index 71cd36f..cde8fd1 100644
--- a/lib/eleventy-plugin-plantuml.js
+++ b/lib/eleventy-plugin-plantuml.js
@@ -8,6 +8,8 @@ const defaultOptions = {
   prefix: "/plantuml",
   outputType: "png",
   imgClass: "plantuml",
+  requestTimeout: undefined,
+  requestSocketTimeout: undefined,
 };
 
 function generatePlantumlUrl(encoded, options) {
@@ -18,7 +20,10 @@ function generatePlantumlUrl(encoded, options) {
 
 const fetchImage = (url, options) => {
   // request url
-  const response = request("GET", url);
+  const response = request("GET", url, {
+    timeout: options.requestTimeout,
+    socketTimeout: options.requestSocketTimeout,
+  });
   // convert from Uint8Array to buffer
   return Buffer.from(response.getBody());
 };
diff --git a/test/eleventy-plugin-plantuml.test.js b/test/eleventy-plugin-plantuml.test.js
index 6f67b8a..9298f39 100644
--- a/test/eleventy-plugin-plantuml.test.js
+++ b/test/eleventy-plugin-plantuml.test.js
@@ -132,4 +132,35 @@ Bob -> Alice : hello
             '<img class="plantuml" src="data:image/png;base64,ABC" alt="Plantuml Diagram" />'
         );
     });
+
+    it("Test request timeout", () => {
+        try {
+            eleventyPluginPlantuml.highlight(
+                `@startuml @enduml`,
+                Object.assign({}, eleventyPluginPlantuml.defaultOptions, {
+                    requestTimeout: 1,
+                })
+            );
+            // should not get here
+            expect(false).beTruthy();
+        } catch (e) {
+            // test passed
+            expect(e).toBeInstanceOf(Error);        }
+    });
+
+    it("Test request socket timeout", () => {
+        try {
+            eleventyPluginPlantuml.highlight(
+                `@startuml @enduml`,
+                Object.assign({}, eleventyPluginPlantuml.defaultOptions, {
+                    requestSocketTimeout: 1,
+                })
+            );
+            // should not get here
+            expect(false).beTruthy();
+        } catch (e) {
+            // test passed
+            expect(e).toBeInstanceOf(Error);
+        }
+    });
 });