Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSV] Registration forms data upload and validations #833

Open
Tracked by #1154
mahalakshme opened this issue Dec 13, 2024 · 0 comments
Open
Tracked by #1154

[CSV] Registration forms data upload and validations #833

mahalakshme opened this issue Dec 13, 2024 · 0 comments

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Dec 13, 2024

AC:

  • Should process the upload even if uploaded with/without descriptor row.
  • Upload should work with headers as in this card. Case insensitive comparison for the headers to be made. If in the headers or the form element there are leading or trailing spaces it needs to be trimmed before comparison. We have got tickets for this.
  • if an entry with 'Id from previous system' already exists do not create or edit and show error 'Entry with id from previous system, 5 already present in Avni'. We currently allow to edit and has led to previous values getting erased.
  • Currently the date format accepted is YYYY-MM-DD. Across all date concepts and column like Registration Date the date format, 'DD-MM-YYYY' needs to be supported. This is inline with what is used in Avni and this is the predominant Indian date format.
  • Values entered for coded concept answers need to be accepted by making case in-sensitive comparison.
    Eg: In APF Odisha, for Pregnancy enrolment, when 'no bank account' entered for column 'Reasons for not enrolling for MAMTA', it shows error message, 'Column: Reasons for not enrolling for MAMTA Error message: Answer concept no bank account not found.'
  • For registration date, show the error message: 'Registration date cannot be in future' when registration date is in the future.
  • Should show error thrown by form element rule when it is violated. When written rule that violates form element rule of 'Age at marriage', doesn't show error: 'Age at marriage cannot be greater than current age.' in the uploaded CSV.

Out of scope:

Edit related improvements

  • For subject registration edit:
    - At least one of the legacy id or UUID need to be present. Else show error: "Mention either Id from previous system or UUID"
    - For editing of forms, the mandatory fields again need not be entered in the CSV to be uploaded. The fields used to identify the entry uniquely, the fields to be updated, and newly created mandatory form elements - with only these update should work. Eg: In APF Odisha, for updating Gravida, only 'Subject UUID' and Gravida need to be entered. Similarly for other forms.

Already handled:

  • When visibility for an entry is true and the field is mandatory and if value not entered shows error as 'Column: Age at marriage Error message: Empty value not allowed.'
  • When visibility for an entry is false and if value for it is entered(if Unmarried and Age entered), value for that not saved
  • When Mandatory column not entered, then shows error message: "Column: Mother's Name Error message: Empty value not allowed."
  • High and Low absolute validation also handled
  • Hiding form element group dynamically also works by not saving the observations to the db
  • Simple decision rule getting executed.
  • Error message when issue in multiple columns: "Invalid 'Enrolment Date', Column: Last menstrual period Error message: Invalid Date Format., Column: Estimated date of delivery Error message: Invalid Date Format., Column: Gravida (the number of pregnancies the woman has had) Error message: Number Below Low Absolute., Column: Height of women Error message: Empty value not allowed., Column: Red Flag (refer MCP card) Error message: Empty value not allowed., Column: Is the beneficiary registered in the AWC? Error message: Empty value not allowed., Column: Bank account opened Error message: Empty value not allowed., Column: Mamata registration Error message: Empty value not allowed., Column: Any history of pregnancy complications Error message: Empty value not allowed., Column: Smoking/ alcohol consumption Error message: Empty value not allowed."
  • Visit schedule rule getting executed and storing the visits.
  • When a text value is entered in place of a numeric value, shows error message, 'Column: Age at marriage Error message: Numeric Value Validation.'
  • For multi-select coded concepts, when multiple answers separated by a comma and followed by a space or without space - works.

Inputs:

  • dd-mm-yyyy is dangerous when used in conjunction with spreadsheets. months and days can get interchanged
  • edit - download and upload
  • CSV upload - user group and permission
  • all system req., - in excel sheet, UI clicks useful when need to incremental changes, or review from application
@mahalakshme mahalakshme converted this from a draft issue Dec 13, 2024
@mahalakshme mahalakshme changed the title [CSV] Forms data upload [CSV] Registration forms data upload and validations Dec 17, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Dec 19, 2024
@mahalakshme mahalakshme moved this from Ready to In Analysis in Avni Product Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Analysis
Development

No branches or pull requests

1 participant