Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV customised location sample file #1531

Closed
Tracked by #1545 ...
mahalakshme opened this issue Feb 28, 2024 · 4 comments
Closed
Tracked by #1545 ...

CSV customised location sample file #1531

mahalakshme opened this issue Feb 28, 2024 · 4 comments
Assignees

Comments

@mahalakshme
Copy link

mahalakshme commented Feb 28, 2024

Issue:

Acceptance criteria:

  • Move download sample file option to the left of upload.
  • Do not show 'Download sample' button for 'Metadata.zip' upload selection.

download_sample

  • Display the location hierarchies based on the configuration in the 'Location Types'. Refer the image below.
    - Have the first option selected by default in both mode and location hierarchy. Should not be able to unselect it by clicking again. Thats how it already works for mode.
    - Display location hierarchies only for create mode and not for other modes
  • Change 'Edit+create' to just 'Edit' mode. Add a tooltip for it that says 'Edit location's name, parent, GPS coordinates or properties'
  • Also move the button locations as shown in below image
Screenshot 2024-05-31 at 4 35 06 PM
  • The sample file should be according to the location hierarchy and mode selected

    1. sample file for create
      - Location hierarchy should be there based on highest to lowest level
      - Placeholder values need to be present as mentioned
      - Ignore last 4 columns mentioned - Out of scope

    2. sample file for Editing location
      - Modify the headers as mentioned in the sample file
      - Have the placeholder fields(3rd row) and descriptor row(2nd row) like mentioned
      - Ignore last 4 columns mentioned - Out of scope

  • Link this here

Ignore the below:

Suggestions:

  • In Edit+create we are allowing to create the lowest location as well - make it to be created only via Create mode.

  • Since we are allowing to update parent - mention the entire hierarchy along with uuid to update to keep the expectation uniform

  • In the locations export, along with titleLineage - mention it in separate columns as well

      -  [sample_locations.csv](https://github.com/avniproject/avni-product/files/15187945/sample_locations.csv) - teachAP sample file when downloaded should be like this
    

When data uploaded with that * it needs to continue to work.

Current behavior that need not be handled:

  • when just mentioned space - doesn't create location with space
  • When lower location mentioned without mentioning higher location - creates orphan lower locations - but this is okay

Note:

  • GPS coordinates and location properties used in reports
  • Though legacy id is supported in Create, didnt mention it in sample file, since it is not used mostly, and might cause confusion.

Inputs:

  • show the location hierachy vs lower location level,
  • if blank should not create
  • Add notes - good to do vs effort - we skip it when processing
  • UUID in the header is fine - is showing as Identifier a antipattern
  • export locations - clean and neat,
  • being able to export metadata as well along with along with transactional LE
  • date, headers,
  • if drop-downs simplifies this, we should think whether we want to move to xlsx and formats supported on other Operating system

Questions:

  • Dual hierarchy like APF odisha?
  • multiple level 1s like in rwb2023
  • How would users know UUID in the Locations page is the ID? - add notes below, change UUID to ID in the webapp UI in the Admin -
  • in RWB - location properties can set up via UI, so they do via CSV, MC also has

Analysis notes:

https://avni.freshdesk.com/a/tickets/2700 - degree in GPS and location already existing
--- degree - solved by data in sample file
--- location already existing - it does error out - so donno whats the case
https://avni.freshdesk.com/a/tickets/2442 - location properties related - possible answers are add, date add - add columns
--- should be fine since configuration is handled by implementation team

@mahalakshme mahalakshme converted this from a draft issue Feb 28, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Feb 29, 2024
@mahalakshme mahalakshme changed the title CSV location sample file for upload having predefined headers CSV customised location sample file May 6, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product May 7, 2024
@mahalakshme mahalakshme moved this from Ready to In Analysis in Avni Product May 8, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product May 9, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product May 22, 2024
@mahalakshme mahalakshme moved this from Ready to In Analysis Review in Avni Product May 27, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product May 27, 2024
@mahalakshme mahalakshme moved this from Ready to In Analysis Review in Avni Product May 27, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product May 27, 2024
@mahalakshme mahalakshme moved this from Ready to In Analysis in Avni Product May 29, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product May 29, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product May 30, 2024
@himeshr himeshr self-assigned this May 30, 2024
@himeshr himeshr moved this from Ready to In Progress in Avni Product May 30, 2024
himeshr added a commit to avniproject/avni-webapp that referenced this issue May 30, 2024
…ction for Locations Upload / Sample download
himeshr added a commit to avniproject/avni-webapp that referenced this issue May 31, 2024
himeshr added a commit to avniproject/avni-server that referenced this issue May 31, 2024
himeshr added a commit to avniproject/avni-server that referenced this issue May 31, 2024
…rchy input params during locations sample file download
himeshr added a commit to avniproject/avni-webapp that referenced this issue May 31, 2024
himeshr added a commit to avniproject/avni-webapp that referenced this issue May 31, 2024
@himeshr himeshr moved this from In Progress to Code Review Ready in Avni Product May 31, 2024
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Jun 5, 2024
@petmongrels petmongrels moved this from In Code Review to QA Ready in Avni Product Jun 5, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jul 1, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Jul 2, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jul 2, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Jul 3, 2024
@AchalaBelokar AchalaBelokar moved this from Done to Triaged in Avni Product Jul 3, 2024
@AchalaBelokar
Copy link

  • I Login with AchalaB@rwbniti the location csv should contain all the location level but dam is not visible in the csv.

sample-locations (9).csv

pls check this

@AchalaBelokar AchalaBelokar moved this from Triaged to QA Failed in Avni Product Jul 3, 2024
@himeshr
Copy link

himeshr commented Jul 3, 2024

  • AchalaB@rwbniti

@AchalaBelokar you would get only those location types, that are part of the selected locationHierarchy.
You would have selected the "Nalla" locationType's hierarchy, therefore the sample has only that and its parent lineage locationTypes.
Screenshot 2024-07-03 at 10 19 15 AM

@himeshr himeshr moved this from QA Failed to QA Ready in Avni Product Jul 3, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to Done in Avni Product Jul 3, 2024
@mahalakshme
Copy link
Author

@AchalaBelokar uuid for location edit not needed, since location names are going to be unique. Just adding here for later reference, since I also keep forgetting the reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants