-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove org specific translations #1443
Comments
|
@vinayvenu we will know when we check for the entity(concept/ report card name etc.,) to which the key belongs to in the db. Or can be figured out as much as possible, and implementors will know better and can be figured out during the discussion with the implementation team. For most of the orgs, will be available in translations table since from lokalise when we upload it creates entry in translations table. But for orgs like RWB2023 I dont see any entries in translations table. for those ll help. |
@vinayvenu I have added this |
Removed from en.json and mr.json in both web app and android app. impl specific ones in en.json also removed from all languages. Spreadsheet including this commit |
Found that none the active orgs use any of the wordings removed in any active concepts. The active orgs that use as well have translations uploaded. So no need to upload translations. Checked with form names in couple of orgs as well. |
|
missing translations are implementation translations |
@Dinesh2019 can you test with prod org with 6.0 apk - the above missing translations are not because of 6.1.0 code change, it was missing from before. |
Motivation:
This is to avoid confusion for the new orgs when they want to translate keys for their organisation. They get confused when they see terms that don't belong to their organisation in lokalise and see that as unnecessary work to translate.
Acceptance criteria:
Record JCB details
andmyDawaPrapatra
in client and webapp codebase.Analysis details:
Some of the keys dont seem to exist as any entity(concept, etc.,) in any of the orgs.
The text was updated successfully, but these errors were encountered: