Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove org specific translations #1443

Closed
mahalakshme opened this issue Nov 30, 2023 · 8 comments
Closed

Remove org specific translations #1443

mahalakshme opened this issue Nov 30, 2023 · 8 comments
Assignees

Comments

@mahalakshme
Copy link

mahalakshme commented Nov 30, 2023

Motivation:

This is to avoid confusion for the new orgs when they want to translate keys for their organisation. They get confused when they see terms that don't belong to their organisation in lokalise and see that as unnecessary work to translate.

Acceptance criteria:

  • Remove keys that doesn't belong to Avni platform(mobile app/webapp respectively) ie.,org specific keys like Record JCB details and myDawaPrapatra in client and webapp codebase.
  • Output a excel file/any file with details of keys removed, should have headings like - 'Key removed', 'Language', 'Translation value', 'Organisation that belonged to', 'Entity type'(which means Report card name or concept name or menu item name, or form name etc.,), 'Platform(Mobile/Web)'
  • Review the above file with implementation team to confirm the necessity of inserting them into translation table because some orgs might not be in use or if we are not sure of the org. After informing the implementation team move this card to 'on Hold'.
  • After reviewing, insert the keys into translation table for the respective organisation, if the key removed is not present

Analysis details:

Some of the keys dont seem to exist as any entity(concept, etc.,) in any of the orgs.

@mahalakshme mahalakshme converted this from a draft issue Nov 30, 2023
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Dec 19, 2023
@mahalakshme mahalakshme moved this from In Analysis Review to In Analysis in Avni Product Dec 19, 2023
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Dec 19, 2023
@vinayvenu
Copy link
Member

  • How do we figure out the organisation that the key belonged to?
  • The scope of this story can stop at creating the excel file and attaching them to this story.

@mahalakshme
Copy link
Author

@vinayvenu we will know when we check for the entity(concept/ report card name etc.,) to which the key belongs to in the db. Or can be figured out as much as possible, and implementors will know better and can be figured out during the discussion with the implementation team. For most of the orgs, will be available in translations table since from lokalise when we upload it creates entry in translations table. But for orgs like RWB2023 I dont see any entries in translations table. for those ll help.

@mahalakshme
Copy link
Author

@vinayvenu I have added this After informing the implementation team move this card to 'on Hold'. The developer need not wait for their response after informing. From a card completion perspective have retained the other points since I think it is better if product team itself completes it to prevent it from missing out and tech knowledge.

@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product Dec 20, 2023
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Dec 21, 2023
@petmongrels petmongrels self-assigned this Dec 21, 2023
@mahalakshme mahalakshme moved this from In Progress to Ready in Avni Product Dec 22, 2023
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Dec 22, 2023
@petmongrels petmongrels self-assigned this Dec 22, 2023
@petmongrels
Copy link

petmongrels commented Dec 22, 2023

Removed from en.json and mr.json in both web app and android app. impl specific ones in en.json also removed from all languages.

Spreadsheet

including this commit

petmongrels added a commit to avniproject/avni-webapp that referenced this issue Dec 22, 2023
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Dec 22, 2023
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Dec 26, 2023
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Dec 26, 2023
@mahalakshme
Copy link
Author

mahalakshme commented Jan 2, 2024

Found that none the active orgs use any of the wordings removed in any active concepts. The active orgs that use as well have translations uploaded. So no need to upload translations. Checked with form names in couple of orgs as well.
CK and IHMP orgs also have translations uploaded, so should not be a problem for them as well.

@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jan 3, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Jan 3, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jan 4, 2024
@AchalaBelokar
Copy link

AchalaBelokar commented Jan 4, 2024

  • I login with maha@rwbniti22 and select language is marathi in the dashboard card approved word is not translated in marathi
  • Then I try to register the work order name should be marathi
  • 3rd page is not translated

Image

  • In the general encounter site Audit translation is not present
  • In the work order daily recording form log book image1 Log book image2 Quantity diesel filled

Image

  • Site Audit form

Image

  • Site Preparedness

Image

Image

@AchalaBelokar AchalaBelokar moved this from In QA to QA Failed in Avni Product Jan 4, 2024
@petmongrels petmongrels moved this from QA Failed to In Progress in Avni Product Jan 8, 2024
@petmongrels petmongrels moved this from In Progress to QA Ready in Avni Product Jan 9, 2024
@petmongrels
Copy link

missing translations are implementation translations

@mahalakshme
Copy link
Author

@Dinesh2019 can you test with prod org with 6.0 apk - the above missing translations are not because of 6.1.0 code change, it was missing from before.
Anything that u see for which translation displaying in prod and not on prerelease is only an issue
Check the above attached excel sheet to ease your work

@Dinesh2019 Dinesh2019 moved this from QA Ready to In QA in Avni Product Jan 9, 2024
@Dinesh2019 Dinesh2019 moved this from In QA to Done in Avni Product Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants