Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency issue in sync #1406

Closed
vinayvenu opened this issue Sep 26, 2023 · 4 comments
Closed

Concurrency issue in sync #1406

vinayvenu opened this issue Sep 26, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@vinayvenu
Copy link
Member

vinayvenu commented Sep 26, 2023

Scenario

When an encounter sync takes a long time, there could be individuals and encounters created, causing sync errors. We should always have a single endDate(now) for the entire duration of the sync.

Acceptance criteria

  • The nowMinus10Seconds returned by the /syncDetails call is used as the now parameter in all sync fetch calls
@vinayvenu vinayvenu moved this to In Analysis in Avni Product Sep 26, 2023
@vinayvenu vinayvenu added the bug Something isn't working label Sep 26, 2023
@mahalakshme
Copy link

@vinayvenu let me know the details that APF reported - it might not be a concurrency issue also - did they they any user name etc.,

@vinayvenu vinayvenu moved this from In Analysis to Analysis Complete in Avni Product Sep 27, 2023
@vinayvenu vinayvenu moved this from Analysis Complete to In Progress in Avni Product Sep 27, 2023
@vinayvenu vinayvenu self-assigned this Sep 27, 2023
vinayvenu added a commit to avniproject/avni-server that referenced this issue Sep 27, 2023
…the Makefile. Use make: Nothing to be done for `../..'. instead
vinayvenu added a commit to avniproject/avni-server that referenced this issue Sep 27, 2023
…s it is always being set in the controller
vinayvenu added a commit to avniproject/avni-server that referenced this issue Sep 27, 2023
@vinayvenu
Copy link
Member Author

This is working as designed. Verified client calls, added test in server to ensure this does not happen. adb logs attached

sync_log.txt

grep "prerelease.avniproject.org" adb_log.txt | grep GET | cut -f7 -d' ' | cut -f4 -d'=' | cut -f1 -d'&' | uniq

@vinayvenu vinayvenu moved this from In Progress to Code Review Ready in Avni Product Sep 27, 2023
@mahalakshme mahalakshme moved this from Code Review Ready to In Code Review in Avni Product Sep 28, 2023
@mahalakshme
Copy link

mahalakshme commented Sep 28, 2023

@AchalaBelokar to test: when an entry, say encounter is created when sync is happening, the encounter should not get synced to the mobile device.

@vinayvenu I think we can add this in readme as sync behavior, will help implementors when debugging. may be here: https://avni.readme.io/docs/internal-details-of-avni-sync#other-tidbits - currently it tells data in the server for more than 10 secs which is not right since it is "start of the sync time" - 10secs right?

@mahalakshme mahalakshme moved this from In Code Review to Code Review with Comments in Avni Product Sep 28, 2023
@vinayvenu
Copy link
Member Author

Done

@vinayvenu vinayvenu moved this from Code Review with Comments to QA Ready in Avni Product Sep 28, 2023
@petmongrels petmongrels moved this from QA Ready to In QA in Avni Product Oct 3, 2023
@petmongrels petmongrels moved this from In QA to Done in Avni Product Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants