Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by media concept #139

Closed
hiralatecf opened this issue Jul 12, 2023 · 5 comments
Closed

Filter by media concept #139

hiralatecf opened this issue Jul 12, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@hiralatecf
Copy link

hiralatecf commented Jul 12, 2023

I am not able to see all the images in the rwbngos2023 organization.
Also filtering is not open for all subjects/encounters?
I want to see images in work order registration but I am not able to.
Thank you

Analysis

Workorder registration images are available, but filtering by the image type is missing. Because of this, you are not able to see them in the list.

Story

As a media viewer used, I would like to be able to filter images by the image concept name so that I can narrow down the list of images to what I want.

eg: In RWB, I would like to get all the pre and post perspective images alone so that I can use them in a report. Currently, it shows everything for a subject, so I get all daily images when I filter by subject. This is about 60 times the number of images that I would want to see. Filtering by concepts helps me narrow it down significantly.

Tech notes

  • API already has the concept name based search available
  • Existing app shows all concepts. Filtering these by concept datatype will help narrow down to our purpose
  • Visualisation already available for concepts (search based dropdown). This can be used
  • Add concept name to the name of the image
@vinayvenu vinayvenu added the bug Something isn't working label Jul 17, 2023
@vinayvenu vinayvenu changed the title All images not shown and filters does not have all subjects/encounters Filter by media concept Jul 27, 2023
@himeshr
Copy link
Contributor

himeshr commented Jul 28, 2023

3 development issues:

  • Token is stored in localStorage and cookies are updated in avni-media for communication
  • Paths need to be env specific config
  • Proxy needs to be reconfigured to avoid cors issues

petmongrels added a commit to avniproject/avni-server that referenced this issue Jul 28, 2023
petmongrels added a commit to avniproject/avni-server that referenced this issue Jul 28, 2023
petmongrels added a commit that referenced this issue Jul 28, 2023
petmongrels added a commit that referenced this issue Jul 31, 2023
petmongrels added a commit to avniproject/avni-server that referenced this issue Jul 31, 2023
petmongrels added a commit that referenced this issue Jul 31, 2023
petmongrels added a commit that referenced this issue Jul 31, 2023
@vinayvenu vinayvenu self-assigned this Aug 1, 2023
@vinayvenu
Copy link
Member

Testing scenarios

  • Single concept
  • Multiple concepts
  • Multiple concepts multiselect
  • Voided concepts
  • Combined with subject filter
  • Combined with Fields filter
  • Combined with Date filter
  • All filters combined together
  • No image scenario

@vinayvenu
Copy link
Member

The filter does not work.

Request
POST /etl/media/search
{"imageConcepts":[{"name":"Image - Farmland","uuid":"fa171bc5-81b9-4842-8014-b3449f069889","dataType":"Image"}]}

Response
http 400

@himeshr himeshr self-assigned this Aug 18, 2023
himeshr added a commit to avniproject/avni-etl that referenced this issue Aug 18, 2023
…rchRequest from ConceptDTO to a "list of string names"
@hiralatecf
Copy link
Author

hiralatecf commented Aug 18, 2023 via email

@himeshr
Copy link
Contributor

himeshr commented Aug 18, 2023

Hi @hiralatecf,
Would like to provide clarification on the card status.
The code changes for this issue will be deployed to prod server (app.avniproject.org) next week, as part of 4.0 release.
The Github cards get closed automatically on QA Complete, the fix is currently available for validation only in pre-release server.

We'll send out a notification mail to you about completion of 4.0 release, after which you may test the fix in Prod.

Kind regards,
Himesh R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants