Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear logs older than 3 months in avni-server #24

Closed
mahalakshme opened this issue Apr 3, 2024 · 6 comments
Closed

Clear logs older than 3 months in avni-server #24

mahalakshme opened this issue Apr 3, 2024 · 6 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Apr 3, 2024

Currently in infra codebase - we are not clearing the old logs and hence logs will keep on getting accumulated. Good to clear the logs older than 3 months.

Reference doc: https://docs.spring.io/spring-boot/docs/2.1.13.RELEASE/reference/html/boot-features-logging.html

@mahalakshme mahalakshme converted this from a draft issue Apr 3, 2024
@himeshr
Copy link
Contributor

himeshr commented Apr 30, 2024

Make use of jvm config logging.file.max-history to specify the number of files to be retained.
Ideally, retaining last 3 months should be more than enough.

@himeshr himeshr moved this from In Analysis to Ready in Avni Product Apr 30, 2024
@himeshr himeshr changed the title Clear logs older than 6 months in avni-server Clear logs older than 3 months in avni-server Apr 30, 2024
@Balamuruganjeevi Balamuruganjeevi moved this from Ready to In Progress in Avni Product Apr 30, 2024
@Balamuruganjeevi Balamuruganjeevi moved this from In Progress to Ready in Avni Product May 6, 2024
@Balamuruganjeevi Balamuruganjeevi moved this from Ready to In Progress in Avni Product May 6, 2024
Balamuruganjeevi added a commit that referenced this issue May 23, 2024
Balamuruganjeevi added a commit that referenced this issue May 24, 2024
Balamuruganjeevi added a commit that referenced this issue May 24, 2024
Balamuruganjeevi added a commit that referenced this issue May 24, 2024
@Balamuruganjeevi Balamuruganjeevi moved this from In Progress to Code Review Ready in Avni Product May 24, 2024
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product May 24, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented May 24, 2024

@Balamuruganjeevi any reason each file was modified in a separate commit?

  • Change to staging_vars.yml looks good.
  • we are not using any of the terraform functionality so the code under provision folder does not need to be touched.
  • Since we currently want to modify configuration for avni-server staging environment, changes to staging_vars.yml is sufficient. Please look at usages of the files before modifying them. In this case, there is no need to modify vars.yml.

@1t5j0y 1t5j0y moved this from In Code Review to Code Review with Comments in Avni Product May 24, 2024
@Balamuruganjeevi Balamuruganjeevi moved this from Code Review with Comments to In Progress in Avni Product May 24, 2024
@Balamuruganjeevi Balamuruganjeevi moved this from In Progress to Code Review Ready in Avni Product May 24, 2024
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product May 24, 2024
@1t5j0y 1t5j0y moved this from In Code Review to In QA in Avni Product May 24, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented May 27, 2024

QA Notes

  • Tested on staging where were no log files between Jan 14 and Feb 21. When this change was deployed on May 24 with the value 90, it deleted logs Feb 21 to Feb 23 but left older log files as-is. When this is deployed to prod, older logs might need to be deleted manually. Added note to Release 9.0 avni-product#1554

@1t5j0y
Copy link
Contributor

1t5j0y commented May 27, 2024

@Balamuruganjeevi please update the max log history for other Avni cloud and RWB environments as well.

@1t5j0y 1t5j0y moved this from In QA to Ready in Avni Product May 27, 2024
@Balamuruganjeevi Balamuruganjeevi moved this from Ready to In Progress in Avni Product May 27, 2024
@Balamuruganjeevi Balamuruganjeevi moved this from In Progress to Code Review Ready in Avni Product May 27, 2024
@Balamuruganjeevi
Copy link
Contributor

@himeshr Updated the config for other environments also. Can you please validate?

@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product May 31, 2024
@petmongrels petmongrels moved this from In Code Review to Code Review Ready in Avni Product May 31, 2024
@himeshr himeshr moved this from Code Review Ready to Done in Avni Product Jun 13, 2024
@himeshr
Copy link
Contributor

himeshr commented Jun 28, 2024

@himeshr Updated the config for other environments also. Can you please validate?

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants