Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to view some media types on Media Viewer #79

Closed
sachsk opened this issue Oct 30, 2023 · 7 comments
Closed

Unable to view some media types on Media Viewer #79

sachsk opened this issue Oct 30, 2023 · 7 comments
Assignees

Comments

@sachsk
Copy link
Member

sachsk commented Oct 30, 2023

Context

When we are uploading the files using the "File" dataType concept those files are not available on the Media viewer.

Acceptance criteria

  • When user uploads the file/audio from the app then it should be available for download in the media viewer.
  • Rename image_url column in media table to media_url

Analysis:

findColumnsMatchingConceptType in MediaTableSyncAction considers only Image and Video

@mahalakshme mahalakshme changed the title Unable to access file on Media Viewers Unable to some media types on Media Viewers Nov 9, 2023
@mahalakshme mahalakshme transferred this issue from avniproject/avni-webapp Nov 9, 2023
@mahalakshme mahalakshme added the enhancement New feature or request label Nov 9, 2023
@mahalakshme mahalakshme changed the title Unable to some media types on Media Viewers Unable to view some media types on Media Viewers Nov 9, 2023
@mahalakshme mahalakshme moved this from Analysis Complete to Ready in Avni Product Nov 9, 2023
@mahalakshme mahalakshme changed the title Unable to view some media types on Media Viewers Unable to view some media types on Media Viewer Nov 9, 2023
@1t5j0y 1t5j0y moved this from Ready to In Progress in Avni Product Nov 10, 2023
@1t5j0y 1t5j0y self-assigned this Nov 10, 2023
1t5j0y added a commit to avniproject/avni-media that referenced this issue Nov 14, 2023
@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Nov 14, 2023
@mahalakshme mahalakshme moved this from Code Review Ready to In Code Review in Avni Product Nov 16, 2023
@mahalakshme
Copy link
Contributor

@1t5j0y this is not done: Rename image_url column in media table to media_url
Can you also please attach a screenshot/video of the media page(with whatever u ve already tested - need not be perfect) here(with file and video/audio thumbnails) - will help for release sign-off showcase, product showcase, else need to spend time to setup.

@mahalakshme mahalakshme moved this from In Code Review to Code Review with Comments in Avni Product Nov 16, 2023
@1t5j0y
Copy link
Contributor

1t5j0y commented Nov 16, 2023

@mahalakshme sure, will do. Hope there are no existing queries in reports etc that expect the column name to be image_url.

@mahalakshme
Copy link
Contributor

@1t5j0y good point, since this is a new table I dont think so, but will confirm once.

@mahalakshme
Copy link
Contributor

@1t5j0y we can assume it is not used in the reports, since I didnt receive any concerns over modifying this from the other team.

@1t5j0y
Copy link
Contributor

1t5j0y commented Nov 17, 2023

Deferring renaming of image_url column due to the impact of having to regenerate etl for all orgs using it (since etl does not support migrations currently).

@1t5j0y
Copy link
Contributor

1t5j0y commented Nov 17, 2023

Screenshot of media viewer with this change:

Audio / Video types use the same 'play button' icon.
File has a different icon.
Images continue to show the actual image.

Image

@1t5j0y 1t5j0y moved this from Code Review with Comments to QA Ready in Avni Product Nov 17, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 17, 2023
@AchalaBelokar
Copy link

I tried to download the audio file Not able to download

@AchalaBelokar AchalaBelokar moved this from In QA to QA Failed in Avni Product Nov 20, 2023
@1t5j0y 1t5j0y moved this from QA Failed to In Progress in Avni Product Nov 21, 2023
1t5j0y added a commit to avniproject/avni-media that referenced this issue Nov 21, 2023
@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Nov 21, 2023
@mahalakshme mahalakshme moved this from Code Review Ready to In Code Review in Avni Product Nov 23, 2023
@mahalakshme mahalakshme moved this from In Code Review to QA Ready in Avni Product Nov 23, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 23, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Nov 23, 2023
@mahalakshme mahalakshme removed the enhancement New feature or request label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants