Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cancel_date_time in the ETL encounter table #64

Closed
Tracked by #1385
nupoorkhandelwal opened this issue Aug 16, 2023 · 1 comment
Closed
Tracked by #1385

Update the cancel_date_time in the ETL encounter table #64

nupoorkhandelwal opened this issue Aug 16, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nupoorkhandelwal
Copy link

Currently, ETL generates a table for each encounter type and has the cancel_date_time column as well, but when an encounter is cancelled, ETL updates that entry in the encounter's cancel table separately. But ideally it should have been done in any of the following ways, in order to avoid confusions to the developers -

  1. Either the cancel_date_time and the last_modified details should get updated in the encounter table as well
  2. Or the cancel_date_time column shouldn't be part of the encounter table in ETL.

On of the above options should be considered and implemented so that devs have clear approach when handling cancel scenarios in the reports logic.

@vinayvenu
Copy link
Member

Cancelling on account of #95

@github-project-automation github-project-automation bot moved this from New Issues to Done in Avni Product Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

2 participants