Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media selection should work as before without asking access for storage permissions #1534

Closed
Tracked by #1465 ...
himeshr opened this issue Oct 17, 2024 · 2 comments
Closed
Tracked by #1465 ...
Assignees

Comments

@himeshr
Copy link
Contributor

himeshr commented Oct 17, 2024

Need:

Need to comply with Google Play store policies related to "READ_MEDIA_IMAGES/READ_MEDIA_VIDEO" permissions.
Currently the deadline for app October 31st 2024 (or Jan 22nd 2025, if we get an extension), failing to meet the acceptable use case criteria will be disallowed from publishing on Google Play.

Acceptance Criteria

  • App should not ask for accessing photos and videos on the device or for accessing storage like available currently. It can ask for taking pictures and recording video
Screen.Recording.2024-10-23.at.6.21.43.PM.mov
  • Without the above should be able to select photos from gallery app or other apps(from all custom albums)
  • Should be able to multi-select photos/videos/audio
  • Above should work in Android version >= 13 across different Android models
  • it should work like this across all models and versions.

Tech Approach

According to this link, looks like GET_CONTENT is supported with the new photo-picker as well. Hence we can import selected images into app without having complete access to Android media storage.

Old: Ignore:

  • Do away with READ_MEDIA_IMAGES and READ_MEDIA_VIDEO privileges
  • Use a system picker, such as the Android photo picker or alternative photoPicker whichever works best for us.
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Oct 17, 2024
@himeshr himeshr moved this from New Issues to Focus Items in Avni Product Oct 17, 2024
@mahalakshme mahalakshme moved this from Focus Items to In Analysis in Avni Product Oct 17, 2024
@mahalakshme mahalakshme changed the title Comply with Google Play store policies related to "READ_MEDIA_IMAGES/READ_MEDIA_VIDEO" permissions Media selection should work as before without asking access for storage permissions Oct 23, 2024
@mahalakshme mahalakshme self-assigned this Oct 24, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Progress in Avni Product Oct 24, 2024
@mahalakshme mahalakshme moved this from In Progress to Code Review Ready in Avni Product Oct 24, 2024
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Oct 24, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Oct 24, 2024
@dinesh2096 dinesh2096 self-assigned this Oct 28, 2024
@mahalakshme
Copy link
Contributor

@dinesh2096 have updated the AC to work in greater than or equal to 13 since for versions < 13, READ_MEDIA_IMAGES/READ_MEDIA_VIDEO permissions are not required. It is different permissions namely 'READ_EXTERNAL_STORAGE' and we need not remove this permission.

@dinesh2096
Copy link

QA Reference video :

Click here to watch the video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants