Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Default Dashboard] Filters should display only for the configured subject type #1530

Closed
Tracked by #1641
mahalakshme opened this issue Oct 4, 2024 · 1 comment
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Oct 4, 2024

Issue:

When any filter is configured for a specific subject type, it needs to show only when that subject type is selected.

Video demonstrating the issue:

https://drive.google.com/file/d/1xr8hk_UFVDNMeYotc-X4f_SZ4gKrMrVm/view?usp=drive_link

Screenshot:

Screenshot 2024-09-25 at 10 16 49 PM

Need:

  • For organisations like Shelter that have many custom my dashboard concept filters applicable to different subject types, it will not be UX friendly to show all filters for all subject types - users will need to scroll more and relevant filters might appear in the bottom with irrelevant on the top, considering we don't have a way to order filters as well.
  • And concepts like WFA Grade, cannot be applicable to subject types like Household and might lead to confusion

AC:

  • In webapp: When any filter, say Gender is configured for a particular subject type, and if 'Subject Type' filter doesn't already exist, save the 'Subject Type' filter as well. This should not lead to saving of duplicate 'Subject Type' filters
  • In Webapp: When any filter, say Gender is configured for a particular subject type, and user tries to remove the existing 'Subject Type' filter, then show an error and disallow the user operation
  • In mobile app: When one of the selected subject types is configured in the filter, then show the filter. Else don't.
  • In mobile app: Whenever there is change in CustomDashboardFilterConfig, clear the CustomDashboardCache after sync of the changes

Analysis notes:

  1. Like subject type we have not made it specific to program and encounter type, because of the below reason:
    Lets say, I want see view all Overdue visits of type 'NRC' of an individual enrolled in program Child, whose WFA grade is 1. And WFA grade is calculated in 'Growth Monitoring visit'. Then I can select Individual subject type, enter WFA grade and select encounter type 'NRC'. ie., it gives me the flexibility to view any visit type for individuals of a particular WFA Grade and especially this works because we are applying concept filters on individuals and not on the encounter that has its value.

  2. Had mentioned the AC here but looks like not clear.

@mahalakshme mahalakshme converted this from a draft issue Oct 4, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Oct 4, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product Nov 26, 2024
@mahalakshme mahalakshme changed the title Dashboard issues of previous release - part 2 [Custom Default Dashboard] Filters should display only for the configured subject type Nov 26, 2024
@himeshr himeshr self-assigned this Nov 26, 2024
himeshr added a commit to avniproject/avni-webapp that referenced this issue Nov 28, 2024
…Type' filter, when there are other dependent filters
himeshr added a commit to avniproject/avni-webapp that referenced this issue Nov 28, 2024
@himeshr
Copy link
Contributor

himeshr commented Nov 28, 2024

Known Issues

  • Changing the Filter type doesnot reset sub-configurations previously set for the filter
  • Multiple Filters can have the same name in the same Custom Dashboard

@himeshr himeshr moved this from In Progress to Code Review Ready in Avni Product Nov 28, 2024
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Nov 29, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Nov 29, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Dec 4, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants