Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clearer error message] Catchment not found #1460

Closed
Tracked by #1485
mahalakshme opened this issue Jul 10, 2024 · 3 comments
Closed
Tracked by #1485

[Clearer error message] Catchment not found #1460

mahalakshme opened this issue Jul 10, 2024 · 3 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Jul 10, 2024

https://avni.freshdesk.com/a/tickets/3443

Issue

version 9.0, prerelease
do not assign a catchment to a user. and sync in mobile app, and see the unreadable error message(exception stacktrace)

Screen.Recording.2024-09-13.at.1.57.25.PM.mov

AC:

  • Display error message stating, 'Contact administrator to configure a catchment for your login to proceed further.'
  • The heading in the error message box 'Sync Failed' can be retained
  • The error messages should be supported in languages: English, Gujarati, Hindi, Kannada, Marathi, Tamil without the need for configuring the translations at the implementation level.

Analysis:

Reasons to do the above:

  • Though we might soon also add validation on User page to add catchment and sync attributes, for existing users without catchment it can still fail
  • anyways above restriction on User page needs more thought(though restriction is there via CSV upload) since for users like API users, sync configuration might not be relevant and might lead to confusion.
@mahalakshme mahalakshme converted this from a draft issue Jul 10, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Jul 10, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to In Analysis in Avni Product Aug 5, 2024
@mahalakshme mahalakshme changed the title Even for errors that can be solved displaying full stacktrace becomes confusing [Clearer error message] Catchment not found Aug 6, 2024
@mahalakshme mahalakshme moved this from In Analysis to Analysis Complete in Avni Product Aug 6, 2024
@mahalakshme mahalakshme moved this from Analysis Complete to Ready in Avni Product Aug 23, 2024
@1t5j0y 1t5j0y moved this from Ready to In Progress in Avni Product Aug 28, 2024
@1t5j0y 1t5j0y self-assigned this Aug 28, 2024
1t5j0y added a commit to avniproject/avni-server that referenced this issue Aug 28, 2024
@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Aug 28, 2024
@petmongrels petmongrels moved this from In Code Review to QA Ready in Avni Product Aug 30, 2024
@dinesh2096 dinesh2096 self-assigned this Oct 20, 2024
@dinesh2096
Copy link

When we change the language of the users the error still display in English language

env : staging
org : Test dashseven
user : dinesh@dashseven

QA Reference :

Click here to watch video

@dinesh2096 dinesh2096 moved this from In QA to QA Failed in Avni Product Oct 22, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Oct 23, 2024

We can't show error message in other language in this scenario since the translations have not synced either due to this failure. Can test if error message is shown in other languages after at least one successful sync happens and then removing the catchment from the user.

@1t5j0y 1t5j0y moved this from QA Failed to QA Ready in Avni Product Oct 23, 2024
@dinesh2096
Copy link

QA Reference :

Click here to watch the video

@dinesh2096 dinesh2096 moved this from In QA to Done in Avni Product Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants