Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing media images #1420

Closed
Tracked by #1538 ...
mahalakshme opened this issue Jun 10, 2024 · 3 comments
Closed
Tracked by #1538 ...

Missing media images #1420

mahalakshme opened this issue Jun 10, 2024 · 3 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Jun 10, 2024

https://avni.freshdesk.com/a/tickets/3932

Need:

We see around for 1.5% of images(for goonj), we can find the URL in the db but the image is not present in S3. We expected this card would have fixed the media upload issue. But looks like more root causes might exist for missing media images.

Analysis:

  • Check this sheet for the missing images in s3
  • Take individual with id, 1582688 whose observations have missing images. The user who synced is in a version which has the above bug fix
  • It doesn't seem to have happened because of media not existing in mobile since replacing of observations with URL has happened

AC:

  • Media should not go missing in s3
@mahalakshme mahalakshme converted this from a draft issue Jun 10, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Jun 10, 2024
@mahalakshme mahalakshme mentioned this issue Jun 10, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Jun 10, 2024
@petmongrels petmongrels self-assigned this Jun 10, 2024
petmongrels added a commit to avniproject/avni-models that referenced this issue Jun 11, 2024
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Jun 11, 2024
petmongrels added a commit that referenced this issue Jun 12, 2024
@mahalakshme
Copy link
Contributor Author

@petmongrels can we try testing it, with slow network connection and more media and see if we can reproduce it. This: #1156 card seems to be tested .May be something similar we can try?

@petmongrels
Copy link
Contributor

  • We have had separate code for cancelling upload etc for slow connections. I am guessing we would have tested it at that time.
  • I have reproduced the problem using wrong url in which case the upload fails now.

@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Jun 12, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Jun 12, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jun 18, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Jun 18, 2024
@1t5j0y 1t5j0y moved this from QA Ready to In QA in Avni Product Jun 19, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Jun 19, 2024

QA Notes

If an error occurs after the url is replaced in the observation, the observation contains multiple entries for the same media item on retry of sync and subsequent success.

screencast-Genymotion-2024-06-19_15.41.33.737.webm

Since we are only popping item from queue after url is updated in observation, an error here is unlikely and should not need a fix.

@1t5j0y 1t5j0y moved this from In QA to Done in Avni Product Jun 19, 2024
himeshr added a commit to avniproject/avni-models that referenced this issue Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants