Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard List View issues #1418

Closed
AchalaBelokar opened this issue Jun 10, 2024 · 2 comments
Closed

Dashboard List View issues #1418

AchalaBelokar opened this issue Jun 10, 2024 · 2 comments
Assignees

Comments

@AchalaBelokar
Copy link

AchalaBelokar commented Jun 10, 2024

Describe the bug
Arrow is not displayed if the dasboard view list is created as listed and while clicking it is popping up

To Reproduce
Steps to reproduce the behavior:

  1. Login to dinesh@mc
  2. change the dashboard which is having the list
  3. click on listed item
  4. See error

Expected behavior
arrow should be clearly visible
Text should not get cut

Screenshots

Screen.Recording.2024-06-07.at.3.37.38.PM.mov
Screenshot 2024-06-07 at 3 52 46 PM

AC:

  • Also we have retained the nos to the right, so I think the arrow should be on the extreme right on the numbers. In the mockups since description is towards the right, I think arrow is on it. But during development if you think arrows on name of the card looks better, we can retain the same. But colour of the arrow needs to be fixed anyways.
  • Text(card name) should not get cut (taqim@sncu)
  • Place percentage inside brackets like in the mockup here
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Jun 10, 2024
@mahalakshme mahalakshme removed the bug label Jun 10, 2024
@mahalakshme mahalakshme changed the title Arrow is not displayed if the dasboard view list is created as listed and while clicking it is popping up Dashboard List View issues Jun 10, 2024
@mahalakshme mahalakshme moved this from New Issues to Ready in Avni Product Jun 10, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Jun 10, 2024
@petmongrels petmongrels self-assigned this Jun 10, 2024
@petmongrels petmongrels moved this from In Progress to Ready in Avni Product Jun 10, 2024
@petmongrels petmongrels removed their assignment Jun 10, 2024
@himeshr himeshr moved this from Ready to In Progress in Avni Product Jun 11, 2024
@himeshr himeshr self-assigned this Jun 11, 2024
@himeshr
Copy link
Contributor

himeshr commented Jun 11, 2024

Done with styling changes as specified in the AC.

Screen.Recording.2024-06-11.at.12.33.29.PM.mov

Secondary values:
Screenshot 2024-06-11 at 12 35 49 PM
Screenshot 2024-06-11 at 12 35 30 PM

Error Message:
Screenshot 2024-06-11 at 12 36 22 PM
Screenshot 2024-06-11 at 12 36 32 PM

@himeshr himeshr moved this from In Progress to Code Review Ready in Avni Product Jun 11, 2024
@mahalakshme
Copy link
Contributor

@AchalaBelokar for text getting cut u can test with Nexus 6 in this card.

@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Jun 11, 2024
@petmongrels petmongrels moved this from In Code Review to Code Review Ready in Avni Product Jun 11, 2024
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Jun 12, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Jun 12, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jun 14, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants