Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable To See Draft Encounter/subject #1321

Closed
Tracked by #1540
vedfordev opened this issue Feb 23, 2024 · 7 comments
Closed
Tracked by #1540

Unable To See Draft Encounter/subject #1321

vedfordev opened this issue Feb 23, 2024 · 7 comments
Assignees

Comments

@vedfordev
Copy link
Contributor

vedfordev commented Feb 23, 2024

Describe the bug
Currently unable to see draft encounter/draft subject.

To Reproduce
Steps to reproduce the behaviour:

  1. login in avni-client with user of org Collectives for Integrated Livelihood Initiatives (UAT)
  2. try to do encounter
  3. go to subject
  4. there is no draft encounter.

Expected behaviour
Draft save should work with subject/encounter/program encounter save
https://avni.freshdesk.com/a/tickets/3577 - Also make sure the issue raised in this ticket would not occur

Smartphone (please complete the following information):
avni-client 6.1

Screen.Recording.2024-02-23.at.5.23.33.PM.mov
@vedfordev vedfordev added the bug label Feb 23, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Feb 23, 2024
@mahalakshme mahalakshme changed the title Unable To See Draft Encounter Unable To See Draft Encounter/subject Feb 26, 2024
@mahalakshme mahalakshme moved this from New Issues to Ready in Avni Product Feb 26, 2024
@mahalakshme mahalakshme removed the bug label Feb 26, 2024
@himeshr himeshr moved this from Ready to In Progress in Avni Product Feb 27, 2024
@himeshr himeshr self-assigned this Feb 27, 2024
@himeshr
Copy link
Contributor

himeshr commented Feb 27, 2024

In general Draft's do not get saved, unless there are no validation errors in the form, when the "Next" button is clicked.
In the case of screen-recording attached here, there seems to not be an issue shown on screen but the date of encounter is before the subjectRegistrationDate, which should have thrown a validation error.

We have been able to create drafts for other encounterTypes in this and other organisations successfully, when there are no validation errors.

@himeshr
Copy link
Contributor

himeshr commented Feb 27, 2024

@Dinesh2019 please reproduce with an org, without having the mobile system date time out of sync from network time.

@Dinesh2019
Copy link

The draft feature is not behaving as expected for encounters. When we started filling the encounter and came out of the page the draft encounter is saved and should displayed after or before the visit planned as that user can easy find the encounter which are saved as draft.

env : prod
org : cini
User : dinesh@cini_uat

Steps to Reproduce :

1.Login to the org
2.go the search page
3.Search of the activity
4.start filling the activity encounter Note : at least first page should be completed to save it as draft
5.click on the page again go the activity

expected : draft should be saved and displayed separately
actual : draft getting saved but not displayed separately

Video References :

My.Movie.mp4

@Dinesh2019 Dinesh2019 moved this from Done to QA Failed in Avni Product May 1, 2024
@vinayvenu vinayvenu reopened this May 1, 2024
@github-project-automation github-project-automation bot moved this from QA Failed to Triaged in Avni Product May 1, 2024
@himeshr himeshr moved this from Triaged to QA Failed in Avni Product May 2, 2024
@1t5j0y 1t5j0y moved this from QA Failed to In Progress in Avni Product May 2, 2024
@1t5j0y 1t5j0y self-assigned this May 2, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented May 2, 2024

@Dinesh2019 this is as expected. Only unscheduled encounters are shown as drafts.

@1t5j0y 1t5j0y moved this from In Progress to QA Ready in Avni Product May 2, 2024
@1t5j0y 1t5j0y moved this from QA Ready to In Progress in Avni Product May 2, 2024
@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product May 3, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented May 3, 2024

Issue is only if user exits encounter via the back button. Home button -> search for subject -> go back to subject was showing the drafts.

Root cause: Draft was being saved but state was not being refreshed on back from the encounter.

Updated https://avni.readme.io/docs/draft-save to reflect current behaviour about display of unscheduled/scheduled encounter drafts

@himeshr himeshr moved this from Code Review Ready to QA Ready in Avni Product May 3, 2024
@Dinesh2019 Dinesh2019 moved this from QA Ready to In QA in Avni Product May 3, 2024
@Dinesh2019
Copy link

If I begin an unscheduled encounter but exit without completing it, saving it as a draft, and then proceed to start a scheduled encounter before finishing the unscheduled one, will the unscheduled encounter draft remain under the draft section, or will it be removed because I initiated the scheduled encounter?

My.Movie.mp4

@Dinesh2019 Dinesh2019 moved this from In QA to QA Failed in Avni Product May 3, 2024
@1t5j0y 1t5j0y moved this from QA Failed to In Progress in Avni Product May 3, 2024
@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product May 3, 2024
@himeshr himeshr moved this from Code Review Ready to QA Ready in Avni Product May 6, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product May 6, 2024
@AchalaBelokar
Copy link

AchalaBelokar commented May 6, 2024

  • Tested on goonj for activity it was working fine there.
  • for genral encounter data saved but not separately like registration
  • tested with schedule encounter

@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

7 participants