Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to multiselect media in one go! #1298

Closed
Tracked by #1515 ...
mahalakshme opened this issue Feb 13, 2024 · 4 comments
Closed
Tracked by #1515 ...

Add ability to multiselect media in one go! #1298

mahalakshme opened this issue Feb 13, 2024 · 4 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Feb 13, 2024

Need:

In usecases, where users are in need to add around 5 images, adding them each time by clicking 'Add More' is a pain. Hence they want to add them in one go.

Acceptance criteria:

  • Being able to multiselect image, video and file that supports multiselect options in one go without the need to click 'Add More' option each time.
  • Scope of this card is within mobile app since currently DEA doesn't support multiselect itself
  • Clicking on 'Add more' should provide the ability to add more media in one go.
  • For audio concept, currently multiselect not supported. if easy then support multiselect for audio concept. Note: package for supporting audio might be different.

Technical details: updated as on 27th March:

  • Found that this feature is supported only from android version 13 in the library we use, and that is enough to support.
  • Refer the attached patch file in the comment for the work that has already been done.

Out of scope:

  • Not for DEA
  • Not for Audio it it takes more than 3 hours.

Suggestions:

no need UI/UX change.

@mahalakshme mahalakshme converted this from a draft issue Feb 13, 2024
@mahalakshme mahalakshme changed the title Add multiselect option for media Add ability to multiselect media in one go! Feb 13, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Feb 13, 2024
@vinayvenu
Copy link
Member

The newer version of react-native-image-picker has a selectionLimit. Setting this to 0 allows an infinite number of images to be selected.

@mahalakshme mahalakshme moved this from Ready to In Analysis in Avni Product Feb 16, 2024
@mahalakshme mahalakshme moved this from In Analysis to Analysis Complete in Avni Product Feb 22, 2024
@mahalakshme mahalakshme moved this from Analysis Complete to Ready in Avni Product Feb 28, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Mar 1, 2024
@petmongrels petmongrels self-assigned this Mar 1, 2024
@petmongrels petmongrels moved this from In Progress to Ready in Avni Product Mar 4, 2024
@petmongrels petmongrels removed their assignment Mar 4, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Mar 4, 2024
@petmongrels petmongrels self-assigned this Mar 4, 2024
@mahalakshme mahalakshme moved this from In Progress to Hold in Avni Product Mar 6, 2024
@mahalakshme mahalakshme moved this from Hold to In Analysis in Avni Product Mar 6, 2024
@petmongrels
Copy link
Contributor

1298.patch

@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Mar 26, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product Mar 27, 2024
@1t5j0y 1t5j0y moved this from Ready to In Progress in Avni Product Mar 28, 2024
@1t5j0y 1t5j0y self-assigned this Mar 28, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Apr 1, 2024

Notes:

  • Audio selection of existing file was broken. Fixed that. Separate story will be needed to properly support Audio MultiSelect form elements.
  • MultiSelect also worked for me on versions of android lower than 13. (Tested on android 11 with google photos as the gallery app).

Testing Scope:

Image - Single and Multi Select
Video - Single and Multi Select
File - Single and Multi Select
Audio - Single Select
All of the above on android >=13 and android < 13

@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Apr 1, 2024
@himeshr himeshr moved this from Code Review Ready to In Code Review in Avni Product Apr 2, 2024
@himeshr himeshr moved this from In Code Review to QA Ready in Avni Product Apr 2, 2024
@Dinesh2019 Dinesh2019 moved this from QA Ready to In QA in Avni Product Apr 2, 2024
@Dinesh2019 Dinesh2019 self-assigned this Apr 2, 2024
@Dinesh2019
Copy link

Dinesh2019 commented Apr 2, 2024

Test env : staging and pre-release

Test scenario :

1.Image video :
- Test uploading a single image
- Verify that only one image can be selected at a time
- Confirm that the uploaded image is displayed correctly
- Test uploading multiple images.
- Verify that multiple images can be selected simultaneously.
- Confirm that all selected images are uploaded and displayed correctly.
- Delete the image and validate the image in removed

2.Video Upload
- Test uploading a single video file.
- Verify that only one video file can be selected at a time.
- Confirm that the uploaded video is displayed correctly.
- Test uploading multiple video files
- Verify that multiple video files can be selected simultaneously
- Confirm that all selected videos are uploaded and displayed correctly
- Delete the video and validate the image in removed

3.File upload
-Test uploading a single file (e.g., PDF, DOC, etc.).
-Verify that only one file can be selected at a time
-Confirm that the uploaded file is displayed correctly
-Test uploading multiple files(pdf,doc,xlsx)
-Verify that multiple files can be selected simultaneously
- Confirm that all selected files are uploaded and displayed correctly
- Delete the file and validate the image in removed

4.Audio Upload:
- Test uploading a single audio file
- Verify that only one image can be selected at a time
- Confirm that the uploaded image is displayed correctly

@Dinesh2019 Dinesh2019 moved this from In QA to Test cases review in Avni Product Apr 2, 2024
@mahalakshme mahalakshme moved this from Test cases review to Done in Avni Product Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants