Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subject type filtered with not retained after sync #1272

Closed
Tracked by #1466
mahalakshme opened this issue Jan 10, 2024 · 2 comments
Closed
Tracked by #1466

Subject type filtered with not retained after sync #1272

mahalakshme opened this issue Jan 10, 2024 · 2 comments
Assignees
@petmongrels

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Jan 10, 2024 •
edited
Loading

Related ticket: https://avni.freshdesk.com/a/tickets/3369

Issue:

  • The subject type selected in dashboard filter is not retained after sync as shown in this video.
  • So, fix made for this card, seems to be broken - may be when applying filters for standard report cards.
  • The subject type retains after sync in apk with build version, 4.01.0-a212 apk.
  • You can use env: prod, login details: maha@jsscp to check the above issue.

Acceptance criteria:

  • Filtered subject type need to retain after sync
  • Technically try to implement it such that we use the same approach for dashboard filters saving so that behaviour for both filters are the same and doesn't cause confusion. Looks like for subject type saving we have used AsyncStorage and for other filters we have used, DashboardCache realm table
@mahalakshme mahalakshme converted this from a draft issue Jan 10, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Jan 10, 2024
@mahalakshme mahalakshme mentioned this issue Jan 10, 2024
Closed
@petmongrels petmongrels self-assigned this Jan 17, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Jan 17, 2024
petmongrels added a commit to avniproject/avni-models that referenced this issue Jan 19, 2024
@petmongrels
avniproject/avni-client#1272 - DashboardCacheFilter class for all the…
d6eff43 
… fields support by Dashboard Cache. Print UUID if possible when throwing mandatory save error. Moved UI code to avni client. Deleted previous cache.
petmongrels added a commit to avniproject/avni-models that referenced this issue Jan 19, 2024
@petmongrels
avniproject/avni-client#1272 - moved filterDate to filter
05ce49d
petmongrels added a commit that referenced this issue Jan 19, 2024
@petmongrels
#1272 - refactored usage of cache and state. more details in the com…
072256a 
…ment in MyDashboardActions.js. Separated Dashboard cache from LocalCacheService.
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Jan 19, 2024
@petmongrels petmongrels moved this from Code Review Ready to In Progress in Avni Product Jan 23, 2024
petmongrels added a commit that referenced this issue Jan 23, 2024
@petmongrels
#1272 - initialise non-subject type related fields. this happens when…
946baf9 
… fast db dump is restored.
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Jan 23, 2024
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Jan 25, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Jan 25, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Feb 1, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Feb 1, 2024
@himeshr himeshr moved this from Done to QA Failed in Avni Product Feb 2, 2024
@himeshr
Copy link
Contributor

himeshr commented Feb 2, 2024 •
edited
Loading

During testing for Embedded objects card, found an error with launching latest version (master branch) apk, in following scenario.

Env: Staging
User: vin@jsscp

  1. Using 6.1 apk login and sync completely. Setup fast-sync.
  2. A. Either upgrade the apk directly without unistalling or clearing user data to master version
    App then errors out after launch with below error stacktrace:
    https://github.com/avniproject/avni-client/assets/72493481/8fc29106-7694-4e42-8e2c-7fbd261655d9

B. Or unistall 6.1 APK and install master apk and login as the same user, with fast-sync
App errors out with improper restore of userInfo, on relaunch app works but user info is lost. My Dashobard Register button is no longer shown and the Dashboard Search fields are also missing.

@himeshr himeshr reopened this Feb 2, 2024
@github-project-automation github-project-automation bot moved this from QA Failed to Triaged in Avni Product Feb 2, 2024
@himeshr himeshr moved this from Triaged to QA Failed in Avni Product Feb 5, 2024
@himeshr
Copy link
Contributor

himeshr commented Feb 5, 2024

During testing for Embedded objects card, found an error with launching latest version (master branch) apk, in following scenario.

Env: Staging User: vin@jsscp

  1. Using 6.1 apk login and sync completely. Setup fast-sync.
  2. A. Either upgrade the apk directly without unistalling or clearing user data to master version
    App then errors out after launch with below error stacktrace:
    https://github.com/avniproject/avni-client/assets/72493481/8fc29106-7694-4e42-8e2c-7fbd261655d9

B. Or unistall 6.1 APK and install master apk and login as the same user, with fast-sync App errors out with improper restore of userInfo, on relaunch app works but user info is lost

I'm currently unable to repoduce the issue with fresh package_manager running and same code base.
The errors encountered could be just due to build packager state issue and not actual bugs.

@himeshr himeshr moved this from QA Failed to Done in Avni Product Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petmongrels petmongrels

Labels
None yet
Projects
Avni Product
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@petmongrels @vinayvenu @mahalakshme @himeshr