Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocalculated value not getting filled #1239

Closed
AchalaBelokar opened this issue Dec 20, 2023 · 3 comments
Closed

Autocalculated value not getting filled #1239

AchalaBelokar opened this issue Dec 20, 2023 · 3 comments
Assignees

Comments

@AchalaBelokar
Copy link

AchalaBelokar commented Dec 20, 2023

Describe the _bug_
Not able to calculate the Nutritional status on skhai app
In child enrolment their is Nutrition status which is auto calculated currently it is not showing
need to login with Ach@sakhiapp

To Reproduce
Steps to reproduce the behavior:

  1. Go to fill the child enrolment form
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots and logs:

Screenshot 2023-12-20 at 11 15 19 AM

Though in logs we see the rule is getting executed, the autocalculated status not getting filled in the above. This issue doesn't exist in prod and Nutritional status gets updated. On a preliminary check, rules in both envs seemed to be the same.

Screenshot 2023-12-20 at 11 15 30 AM
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Dec 20, 2023
@mahalakshme mahalakshme moved this from New Issues to Ready in Avni Product Dec 20, 2023
@mahalakshme mahalakshme changed the title Not able to calculate the Nutritional status on skhai app Autocalculated value not getting filled Dec 20, 2023
@1t5j0y 1t5j0y moved this from Ready to In Progress in Avni Product Dec 20, 2023
@1t5j0y 1t5j0y self-assigned this Dec 20, 2023
@AchalaBelokar
Copy link
Author

  • Login with dinesh@adsr there is encounter Annual visit baseline Which contain medical details there is auto calculated value BMI it is not generated .

Image

@1t5j0y
Copy link
Contributor

1t5j0y commented Dec 20, 2023

Introduced in #1037.

Fix - Allowed nil observations to be updated by form element status rules as this is the common use case of using these rules.

This has the side effect that any editable form elements which have form element statuses cannot be edited to completely remove the value. Fixing this side effect might require significant refactoring of the original story.

Side effect behaviour:
https://github.com/avniproject/avni-client/assets/54208632/401c3f0a-e95c-4499-9913-6f66694087c6

@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Dec 20, 2023
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Dec 20, 2023
@petmongrels
Copy link
Contributor

@AchalaBelokar this needs thorough testing of the form wizard. pls take help from Dinesh also.

@petmongrels petmongrels moved this from In Code Review to QA Ready in Avni Product Dec 20, 2023
@mahalakshme mahalakshme moved this from QA Ready to Done in Avni Product Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants