Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to configure the server url for fresh installation #1191

Closed
deeptirawat1510 opened this issue Nov 20, 2023 · 6 comments
Closed

Ability to configure the server url for fresh installation #1191

deeptirawat1510 opened this issue Nov 20, 2023 · 6 comments
Assignees

Comments

@deeptirawat1510
Copy link
Contributor

deeptirawat1510 commented Nov 20, 2023

Motivation

We don't need to build different environments separately in same flavour.

Acceptance Criteria

As a user installing the application for the first time, I want to see a new UI before the login screen.

Visual Design

Screenshot 2023-11-20 at 5 39 53 PM

Tech Approach

  1. If a URL is present in the async storage, the modified settings service should retrieve it.
  2. If no URL is present in async storage, the application should display the default UI.
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Nov 20, 2023
deeptirawat1510 added a commit to deeptirawat1510/avni-client that referenced this issue Nov 20, 2023
@vinayvenu vinayvenu moved this from New Issues to In Code Review in Avni Product Nov 21, 2023
vinayvenu added a commit that referenced this issue Nov 21, 2023
#1191 | Implemented the functionality to configure the server url.
@vinayvenu vinayvenu moved this from In Code Review to QA Ready in Avni Product Nov 21, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 21, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Nov 21, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 23, 2023
@AchalaBelokar
Copy link

AchalaBelokar commented Nov 23, 2023

@AchalaBelokar AchalaBelokar moved this from In QA to QA Failed in Avni Product Nov 23, 2023
@ashusvnath
Copy link

@AchalaBelokar : This wont work for the apk's currently being built in our pipeline.
A new apk needs to be built with no_env.

@vinayvenu
Copy link
Member

@AchalaBelokar please follow instructions in https://avni.readme.io/docs/release-process-for-the-cloud#circleci-build with the value of flavor set to no_env.

@vinayvenu vinayvenu moved this from QA Failed to QA Ready in Avni Product Nov 24, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 24, 2023
@AchalaBelokar
Copy link

@vinayvenu I tried with generate flavour set to no_env , circle ci don’t allow me to add flavour .

@vinayvenu vinayvenu moved this from In QA to QA Failed in Avni Product Nov 24, 2023
@ashusvnath ashusvnath self-assigned this Nov 24, 2023
@ashusvnath ashusvnath moved this from QA Failed to In Progress in Avni Product Nov 24, 2023
@1t5j0y
Copy link
Contributor

1t5j0y commented Nov 24, 2023

As I understand it, no_env is not a flavor, it is an environment, so we will either need to:

  • add circleci config to add an entry to generate no_env apks if this is going to be regularly required
    OR
  • someone generates a no_env apk for Achala to test this story

@ashusvnath
Copy link

ashusvnath commented Nov 24, 2023

@1t5j0y , @vinayvenu : I'm going create a gated stage that builds with no_env config and generic flavor on CI

@ashusvnath ashusvnath moved this from In Progress to QA Ready in Avni Product Nov 24, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 27, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Nov 27, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 27, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants