Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync button stays disabled if background sync fails #1177

Closed
1t5j0y opened this issue Nov 8, 2023 · 2 comments
Closed

Sync button stays disabled if background sync fails #1177

1t5j0y opened this issue Nov 8, 2023 · 2 comments
Assignees
Labels

Comments

@1t5j0y
Copy link
Contributor

1t5j0y commented Nov 8, 2023

Steps to reproduce
Login with a user for whom sync is failing.
Background sync gets triggered (some scenarios mentioned below).
Sync button stays disabled even though background sync attempt has completed (has failed).

The above is an easier way to reproduce the issue but the issue could occur from any temporary failure during automatic sync as well which would lead to user being unable to sync manually (for at least an hour when the next automatic sync runs and completes successfully).

Expected behaviour
Sync button should only be disabled while background sync is ongoing. It should be enabled when background sync completes (either succeeds or fails) so that users can sync when they want.

Scenarios
Login -> Automatic foreground sync -> Automatic background sync
Update from older version of app -> Launch app -> automatic background sync

@1t5j0y 1t5j0y converted this from a draft issue Nov 8, 2023
@mahalakshme mahalakshme moved this from New Issues to Focus Items in Avni Product Nov 8, 2023
@mahalakshme mahalakshme added the bug label Nov 8, 2023
@mahalakshme mahalakshme moved this from Focus Items to In Analysis in Avni Product Nov 8, 2023
@mahalakshme
Copy link
Contributor

@1t5j0y kindly add steps to reproduce. Since u have already seen the issue, would be easier for u.

@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Nov 9, 2023
@ashusvnath ashusvnath self-assigned this Nov 9, 2023
@ashusvnath ashusvnath moved this from Ready to In Progress in Avni Product Nov 9, 2023
ashusvnath pushed a commit that referenced this issue Nov 9, 2023
@ashusvnath
Copy link

Dev Testing:

Setup: The sync schedule timings was reduced to 15 minutes. Avni client was started in dev mode. Log into the application. The lastSyncExecution check was bypassed. The local avni server was stopped.
Observation: The sync icon on the app was not disabled even after multiple intervals of 15 minutes.

@ashusvnath ashusvnath moved this from In Progress to Code Review Ready in Avni Product Nov 9, 2023
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Nov 9, 2023
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Nov 9, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 10, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants