-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync button stays disabled if background sync fails #1177
Labels
Comments
@1t5j0y kindly add steps to reproduce. Since u have already seen the issue, would be easier for u. |
Dev Testing:Setup: The sync schedule timings was reduced to 15 minutes. Avni client was started in dev mode. Log into the application. The lastSyncExecution check was bypassed. The local avni server was stopped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
Login with a user for whom sync is failing.
Background sync gets triggered (some scenarios mentioned below).
Sync button stays disabled even though background sync attempt has completed (has failed).
The above is an easier way to reproduce the issue but the issue could occur from any temporary failure during automatic sync as well which would lead to user being unable to sync manually (for at least an hour when the next automatic sync runs and completes successfully).
Expected behaviour
Sync button should only be disabled while background sync is ongoing. It should be enabled when background sync completes (either succeeds or fails) so that users can sync when they want.
Scenarios
Login -> Automatic foreground sync -> Automatic background sync
Update from older version of app -> Launch app -> automatic background sync
The text was updated successfully, but these errors were encountered: