Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for devices without telephony enabled #1157

Closed
vinayvenu opened this issue Oct 26, 2023 · 3 comments
Closed

Support for devices without telephony enabled #1157

vinayvenu opened this issue Oct 26, 2023 · 3 comments
Assignees

Comments

@vinayvenu
Copy link
Member

Context

Many devices are disabled from using Avni because they don't have telephony enabled. However, most Avni use-cases do not require telephony.

Acceptance criteria

As a user of a device without telephony enabled, when I search for Avni on the playstore, I need to be able to find and install it.

Image

@vinayvenu vinayvenu moved this to Ready in Avni Product Oct 26, 2023
@himeshr himeshr moved this from Ready to In Progress in Avni Product Oct 27, 2023
@himeshr himeshr self-assigned this Oct 27, 2023
@himeshr himeshr moved this from In Progress to Ready in Avni Product Oct 27, 2023
@himeshr himeshr removed their assignment Oct 27, 2023
@vinayvenu vinayvenu moved this from Ready to QA Failed in Avni Product Oct 27, 2023
@vinayvenu vinayvenu moved this from QA Failed to In Progress in Avni Product Oct 27, 2023
@vinayvenu vinayvenu self-assigned this Oct 27, 2023
@vinayvenu vinayvenu moved this from In Progress to Code Review Ready in Avni Product Oct 27, 2023
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Oct 27, 2023
@himeshr himeshr moved this from In Code Review to Code Review with Comments in Avni Product Oct 27, 2023
@himeshr
Copy link
Contributor

himeshr commented Oct 27, 2023

As per documentation, https://developer.android.com/guide/topics/manifest/uses-permission-element, android:required="false" has to be set in .

@himeshr
Copy link
Contributor

himeshr commented Oct 27, 2023

For this entry,

<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />

There is a warning about following:

Caution: If your app targets Android 5.0 (API level 21) or higher and uses the ACCESS_COARSE_LOCATION or ACCESS_FINE_LOCATION permission to receive location updates from the network or a GPS, respectively, you must also explicitly declare that your app uses the android.hardware.location.network or android.hardware.location.gps hardware features.

For this entry,

 <uses-permission android:name="android.hardware.telephony" android:required="false"/>

The value android:name="android.hardware.telephony" might not be accepted, as it refers to a Implied feature requirement and not a type of Permission.
See https://developer.android.com/guide/topics/manifest/uses-feature-element#permissions-features
and https://developer.android.com/reference/android/Manifest.permission#CALL_PHONE

@vinayvenu vinayvenu moved this from Code Review with Comments to In Progress in Avni Product Oct 27, 2023
vinayvenu added a commit that referenced this issue Oct 27, 2023
@vinayvenu
Copy link
Member Author

Image

@vinayvenu vinayvenu moved this from In Progress to Code Review Ready in Avni Product Oct 31, 2023
@himeshr himeshr moved this from Code Review Ready to QA Ready in Avni Product Nov 1, 2023
@Dinesh2019 Dinesh2019 moved this from QA Ready to In QA in Avni Product Nov 2, 2023
@Dinesh2019 Dinesh2019 moved this from In QA to Done in Avni Product Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants